Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 2108623005: extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index bd1c4c978c696978b8347d9f2cd7c307f0e7f0e5..2335be015dcd37ca5c2769198fbd46432a68c90d 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -239,7 +239,7 @@ void WebViewGuest::CleanUp(content::BrowserContext* browser_context,
view_instance_id));
// Clean up content scripts for the WebView.
- auto csm = WebViewContentScriptManager::Get(browser_context);
+ auto* csm = WebViewContentScriptManager::Get(browser_context);
csm->RemoveAllContentScriptsForWebView(embedder_process_id, view_instance_id);
// Allow an extensions browser client to potentially perform more cleanup.
@@ -303,7 +303,7 @@ int WebViewGuest::GetOrGenerateRulesRegistryID(
if (it != web_view_key_to_id_map.Get().end())
return it->second;
- auto rph = RenderProcessHost::FromID(embedder_process_id);
+ auto* rph = RenderProcessHost::FromID(embedder_process_id);
int rules_registry_id =
RulesRegistryService::Get(rph->GetBrowserContext())->
GetNextRulesRegistryID();
@@ -347,7 +347,7 @@ void WebViewGuest::CreateWebContents(
// If we already have a webview tag in the same app using the same storage
// partition, we should use the same SiteInstance so the existing tag and
// the new tag can script each other.
- auto guest_view_manager = GuestViewManager::FromBrowserContext(
+ auto* guest_view_manager = GuestViewManager::FromBrowserContext(
owner_render_process_host->GetBrowserContext());
scoped_refptr<content::SiteInstance> guest_site_instance =
guest_view_manager->GetGuestSiteInstance(guest_site);
@@ -987,7 +987,7 @@ void WebViewGuest::RequestPointerLockPermission(
}
void WebViewGuest::SignalWhenReady(const base::Closure& callback) {
- auto manager = WebViewContentScriptManager::Get(browser_context());
+ auto* manager = WebViewContentScriptManager::Get(browser_context());
manager->SignalOnScriptsLoaded(callback);
}
@@ -1153,7 +1153,7 @@ void WebViewGuest::SetName(const std::string& name) {
}
void WebViewGuest::SetZoom(double zoom_factor) {
- auto zoom_controller = ZoomController::FromWebContents(web_contents());
+ auto* zoom_controller = ZoomController::FromWebContents(web_contents());
DCHECK(zoom_controller);
double zoom_level = content::ZoomFactorToZoomLevel(zoom_factor);
zoom_controller->SetZoomLevel(zoom_level);
@@ -1317,7 +1317,7 @@ void WebViewGuest::WebContentsCreated(WebContents* source_contents,
const std::string& frame_name,
const GURL& target_url,
WebContents* new_contents) {
- auto guest = WebViewGuest::FromWebContents(new_contents);
+ auto* guest = WebViewGuest::FromWebContents(new_contents);
CHECK(guest);
guest->SetOpener(this);
guest->name_ = frame_name;
@@ -1409,7 +1409,7 @@ void WebViewGuest::RequestNewWindowPermission(WindowOpenDisposition disposition,
const gfx::Rect& initial_bounds,
bool user_gesture,
WebContents* new_contents) {
- auto guest = WebViewGuest::FromWebContents(new_contents);
+ auto* guest = WebViewGuest::FromWebContents(new_contents);
if (!guest)
return;
auto it = pending_new_windows_.find(guest);
@@ -1461,7 +1461,7 @@ void WebViewGuest::OnWebViewNewWindowResponse(
int new_window_instance_id,
bool allow,
const std::string& user_input) {
- auto guest =
+ auto* guest =
WebViewGuest::From(owner_web_contents()->GetRenderProcessHost()->GetID(),
new_window_instance_id);
if (!guest)

Powered by Google App Engine
This is Rietveld 408576698