extensions/browser/extension_navigation_throttle.cc - Issue 2108623005: extensions: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_navigation_throttle.cc

Issue 2108623005: extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/event_router.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_navigation_throttle.cc

diff --git a/extensions/browser/extension_navigation_throttle.cc b/extensions/browser/extension_navigation_throttle.cc

index 235c779cafb7aa859eef19f844940fe92ac57c7d..bdf1a27af56d003b7374132a946fb4c715992407 100644

--- a/extensions/browser/extension_navigation_throttle.cc

+++ b/extensions/browser/extension_navigation_throttle.cc

@@ -44,7 +44,7 @@ ExtensionNavigationThrottle::WillStartRequest() {

// the ancestor chain, so find the current RenderFrameHost and use it to

// traverse up to the main frame.

content::RenderFrameHost* navigating_frame = nullptr;

- for (auto frame : navigation_handle()->GetWebContents()->GetAllFrames()) {

+ for (auto* frame : navigation_handle()->GetWebContents()->GetAllFrames()) {

if (frame->GetFrameTreeNodeId() ==

navigation_handle()->GetFrameTreeNodeId()) {

navigating_frame = frame;

« no previous file with comments | « extensions/browser/event_router.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »