Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 2108623005: extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.cc ('k') | extensions/test/test_extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index ee7c11e6dd8237c69ab666b45d482010dde2bf36..e63c434ac44a3ccf8733072d7237adb9a241cfa2 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -137,7 +137,7 @@ void GuestViewInternalCustomBindings::AttachGuest(
int element_instance_id = args[0]->Int32Value();
// An element instance ID uniquely identifies a GuestViewContainer.
- auto guest_view_container =
+ auto* guest_view_container =
guest_view::GuestViewContainer::FromID(element_instance_id);
// TODO(fsamuel): Should we be reporting an error if the element instance ID
@@ -182,7 +182,7 @@ void GuestViewInternalCustomBindings::DetachGuest(
int element_instance_id = args[0]->Int32Value();
// An element instance ID uniquely identifies a GuestViewContainer.
- auto guest_view_container =
+ auto* guest_view_container =
guest_view::GuestViewContainer::FromID(element_instance_id);
// TODO(fsamuel): Should we be reporting an error if the element instance ID
@@ -382,7 +382,7 @@ void GuestViewInternalCustomBindings::RegisterElementResizeCallback(
int element_instance_id = args[0]->Int32Value();
// An element instance ID uniquely identifies a ExtensionsGuestViewContainer
// within a RenderView.
- auto guest_view_container = static_cast<ExtensionsGuestViewContainer*>(
+ auto* guest_view_container = static_cast<ExtensionsGuestViewContainer*>(
guest_view::GuestViewContainer::FromID(element_instance_id));
if (!guest_view_container)
return;
@@ -408,7 +408,7 @@ void GuestViewInternalCustomBindings::RegisterView(
// ID as the key. The reference is made weak so that it will not extend the
// lifetime of the object.
int view_instance_id = args[0]->Int32Value();
- auto object =
+ auto* object =
new v8::Global<v8::Object>(args.GetIsolate(), args[1].As<v8::Object>());
weak_view_map.Get().insert(std::make_pair(view_instance_id, object));
« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.cc ('k') | extensions/test/test_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698