Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed)

Created:
4 years, 5 months ago by afakhry
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Offer user to send feedback from profile error dialog This CL makes the following: - Improves the wording of the profile error dialog so as not to confuse users - Adds a checkbox to offer the user to send a feedback report. - Prepopulates the feedback description to ask the user what happened, and to add more debugging info (currently the name of the corrupted file). - File the profile-error feedback reports under a category with name "FEEDBACK_PROFILE_ERROR" Screenshots: - Profile error dialog: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_La0tBU2RWTEdXQ28/view?usp=sharing - Prepopulated feedback app - 1: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LZ19obE1Xa0hNSEE/view?usp=sharing - Prepopulated feedback app - 2: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LZFc4WjdxcjFwN28/view?usp=sharing BUG=455749 Committed: https://crrev.com/7c9abe71bce004b6b3af1cef691f7ca8a455e56b Cr-Commit-Position: refs/heads/master@{#410094}

Patch Set 1 #

Patch Set 2 : Fix compile errors on non-chrome os platforms #

Patch Set 3 : Fix more compile errors #

Patch Set 4 : TODO: implement the checkbox on mac cocoa. #

Patch Set 5 : Unused variable #

Total comments: 10

Patch Set 6 : tapted's and shess' #

Patch Set 7 : Gather more diagnostics about the database. #

Patch Set 8 : Fix compile error #

Patch Set 9 : Yet more compile errors #

Total comments: 57

Patch Set 10 : Reviewers comments #

Patch Set 11 : Fix Windows compile errors #

Patch Set 12 : wchar_t #

Total comments: 9

Patch Set 13 : Ditching the map and using CollectCorruptionInfo() and CollectErrorInfo() instead of duplication #

Patch Set 14 : ios compile error #

Total comments: 11

Patch Set 15 : Avoid a ref loop. #

Total comments: 8

Patch Set 16 : More comments #

Total comments: 7

Patch Set 17 : rebase and sky comments #

Total comments: 4

Patch Set 18 : sky's comments and some improvements to the code. #

Total comments: 24

Patch Set 19 : Rebase and sky's comments #

Patch Set 20 : sky's comments #

Total comments: 2

Patch Set 21 : sky's #

Total comments: 14

Patch Set 22 : pkasting's & droger's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -155 lines) Patch
M android_webview/browser/aw_form_database_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +12 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/chrome_history_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/chrome_history_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 7 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/ui/android/simple_message_box_android.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/simple_message_box_mac.mm View 1 2 3 4 5 6 7 8 9 4 chunks +32 lines, -4 lines 0 comments Download
M chrome/browser/ui/profile_error_dialog.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/ui/profile_error_dialog.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -7 lines 0 comments Download
M chrome/browser/ui/simple_message_box.h View 1 2 3 4 5 6 7 8 9 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 10 chunks +43 lines, -22 lines 0 comments Download
M chrome/browser/web_data_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/history_backend.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +8 lines, -1 line 0 comments Download
M components/history/core/browser/history_backend.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +10 lines, -5 lines 0 comments Download
M components/history/core/browser/history_backend_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/history_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/history_database.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +3 lines, -2 lines 0 comments Download
M components/history/core/browser/history_database.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +12 lines, -4 lines 0 comments Download
M components/history/core/browser/history_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/history_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +6 lines, -4 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/test/history_client_fake_bookmarks.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/test/history_client_fake_bookmarks.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M components/webdata/common/web_data_service_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M components/webdata/common/web_database.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -0 lines 0 comments Download
M components/webdata/common/web_database.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M components/webdata/common/web_database_backend.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +16 lines, -1 line 0 comments Download
M components/webdata/common/web_database_backend.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 6 chunks +22 lines, -8 lines 0 comments Download
M components/webdata/common/web_database_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +7 lines, -5 lines 0 comments Download
M components/webdata/common/web_database_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +12 lines, -12 lines 0 comments Download
M components/webdata_services/web_data_service_wrapper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +8 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/history/history_client_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/history/history_client_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/web_data_service_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -2 lines 0 comments Download
M sql/connection.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M sql/connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +35 lines, -17 lines 0 comments Download
M sql/error_delegate_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +12 lines, -0 lines 0 comments Download
M sql/error_delegate_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +9 lines, -0 lines 0 comments Download
M ui/views/controls/message_box_view.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 114 (60 generated)
afakhry
shess@: for suggestions about what other useful debugging info that we can attach to the ...
4 years, 5 months ago (2016-06-28 18:45:38 UTC) #4
tapted
https://codereview.chromium.org/2107493002/diff/120001/chrome/browser/ui/cocoa/simple_message_box_mac.mm File chrome/browser/ui/cocoa/simple_message_box_mac.mm (right): https://codereview.chromium.org/2107493002/diff/120001/chrome/browser/ui/cocoa/simple_message_box_mac.mm#newcode39 chrome/browser/ui/cocoa/simple_message_box_mac.mm:39: } If OWNERS like the API changes in general, ...
4 years, 5 months ago (2016-06-29 03:19:55 UTC) #5
Scott Hess - ex-Googler
On 2016/06/28 18:45:38, afakhry wrote: > shess@: > for suggestions about what other useful debugging ...
4 years, 5 months ago (2016-06-29 05:13:48 UTC) #6
afakhry
Regarding the extra suggested diagnostic info, if time permits, I'll add them as part of ...
4 years, 5 months ago (2016-06-29 18:57:19 UTC) #7
Scott Hess - ex-Googler
On 2016/06/29 18:57:19, afakhry wrote: > Regarding the extra suggested diagnostic info, if time permits, ...
4 years, 5 months ago (2016-06-29 19:17:27 UTC) #8
afakhry
I added more diagnostic information to the pre-populated feedback description as suggested by shess@. Many ...
4 years, 5 months ago (2016-07-09 00:45:51 UTC) #12
Lei Zhang
Wow, that feels like a lot of plumbing. Is there any way of connecting the ...
4 years, 5 months ago (2016-07-09 01:04:47 UTC) #13
Lei Zhang
Apparently I'm suffering from packet loss. On 2016/07/09 01:04:47, Lei Zhang wrote: > Wow, that ...
4 years, 5 months ago (2016-07-09 01:07:21 UTC) #14
michaeln
that is a lot of plumbing https://codereview.chromium.org/2107493002/diff/200001/chrome/browser/prefs/chrome_pref_service_factory.cc File chrome/browser/prefs/chrome_pref_service_factory.cc (right): https://codereview.chromium.org/2107493002/diff/200001/chrome/browser/prefs/chrome_pref_service_factory.cc#newcode381 chrome/browser/prefs/chrome_pref_service_factory.cc:381: {{"Corrupted file", pref_filename.AsUTF8Unsafe()}}))); ...
4 years, 5 months ago (2016-07-09 03:00:38 UTC) #15
Scott Hess - ex-Googler
Comments from the peanut gallery - your chosen reviewers should take precedence (and they should ...
4 years, 5 months ago (2016-07-10 05:16:52 UTC) #16
afakhry
Apologies for the much plumbing, but it had to be done. https://codereview.chromium.org/2107493002/diff/200001/chrome/browser/prefs/chrome_pref_service_factory.cc File chrome/browser/prefs/chrome_pref_service_factory.cc (right): ...
4 years, 5 months ago (2016-07-11 16:47:46 UTC) #19
afakhry
+estade@ Could you please take a look at the SimpleMessageBox changes? Thanks.
4 years, 5 months ago (2016-07-11 16:50:31 UTC) #20
Evan Stade
https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc#newcode150 chrome/browser/ui/views/simple_message_box_views.cc:150: if (!has_checkbox_ || message_box_view_->IsCheckBoxSelected()) So we don't allow the ...
4 years, 5 months ago (2016-07-12 18:36:58 UTC) #21
michaeln
https://codereview.chromium.org/2107493002/diff/200001/components/history/core/browser/history_backend.cc File components/history/core/browser/history_backend.cc (right): https://codereview.chromium.org/2107493002/diff/200001/components/history/core/browser/history_backend.cc#newcode2424 components/history/core/browser/history_backend.cc:2424: db_diagnostics_ = db_->GetDiagnosticMap(); This function is similar to Connection::ReportDiagnosticInfo ...
4 years, 5 months ago (2016-07-12 20:05:32 UTC) #22
michaeln
Oh, there's some duplicated code, would it make sense to use the existing diag gathering ...
4 years, 5 months ago (2016-07-12 21:00:07 UTC) #23
Scott Hess - ex-Googler
I had a few more minutes to comment, but will disappear soon. So, again, take ...
4 years, 5 months ago (2016-07-13 01:18:46 UTC) #24
afakhry
Please, also take a look at the updated second and third screenshots in the CL ...
4 years, 5 months ago (2016-07-13 19:57:59 UTC) #32
afakhry
Friendly ping.
4 years, 5 months ago (2016-07-15 18:10:47 UTC) #39
Evan Stade
message box lgtm https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc#newcode96 chrome/browser/ui/views/simple_message_box_views.cc:96: has_checkbox_(!checkbox_text.empty()) { I would consider moving ...
4 years, 5 months ago (2016-07-15 18:25:48 UTC) #40
michaeln
https://codereview.chromium.org/2107493002/diff/300001/components/webdata/common/web_database_backend.cc File components/webdata/common/web_database_backend.cc (right): https://codereview.chromium.org/2107493002/diff/300001/components/webdata/common/web_database_backend.cc#newcode63 components/webdata/common/web_database_backend.cc:63: base::StringAppendF(&db_diagnostics_, "Corrupted file: %s\n", Ah, i guess the filename ...
4 years, 5 months ago (2016-07-15 23:30:57 UTC) #41
michaeln
Hmmm... i'm looking at how ReportDiagnosticInfo() is currently being used by ThumbnailDatabase and am wondering ...
4 years, 5 months ago (2016-07-16 00:02:51 UTC) #42
Lei Zhang
https://codereview.chromium.org/2107493002/diff/320001/chrome/browser/prefs/chrome_pref_service_factory.cc File chrome/browser/prefs/chrome_pref_service_factory.cc (right): https://codereview.chromium.org/2107493002/diff/320001/chrome/browser/prefs/chrome_pref_service_factory.cc#newcode377 chrome/browser/prefs/chrome_pref_service_factory.cc:377: diagnostics += pref_filename.DirName().BaseName().AsUTF8Unsafe() + "/" + Do you care ...
4 years, 5 months ago (2016-07-16 00:35:21 UTC) #43
afakhry
https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/2107493002/diff/260001/chrome/browser/ui/views/simple_message_box_views.cc#newcode96 chrome/browser/ui/views/simple_message_box_views.cc:96: has_checkbox_(!checkbox_text.empty()) { On 2016/07/15 18:25:48, Evan Stade wrote: > ...
4 years, 5 months ago (2016-07-18 17:43:51 UTC) #46
afakhry
On 2016/07/16 00:02:51, michaeln wrote: > Hmmm... i'm looking at how ReportDiagnosticInfo() is currently being ...
4 years, 5 months ago (2016-07-18 17:49:03 UTC) #47
Lei Zhang
chrome/ lgtm
4 years, 5 months ago (2016-07-18 19:31:42 UTC) #50
michaeln
lgtm 2 On 2016/07/18 17:49:03, afakhry wrote: > On 2016/07/16 00:02:51, michaeln wrote: > > ...
4 years, 5 months ago (2016-07-18 20:05:50 UTC) #51
afakhry
torne@chromium.org: Please review changes in aw_form_database_service.cc sky@chromium.org: Please review changes in components/ and ui/. https://codereview.chromium.org/2107493002/diff/300001/chrome/browser/ui/views/simple_message_box_views.cc ...
4 years, 5 months ago (2016-07-18 20:21:28 UTC) #53
sky
I only looked at components/history. Please split your patch up into smaller chunks. Also, you ...
4 years, 5 months ago (2016-07-18 21:06:01 UTC) #54
Torne
android_webview LGTM
4 years, 5 months ago (2016-07-19 11:37:54 UTC) #55
afakhry
Re sky: Thanks for the review! - shess@ is not coming until Aug 7th and ...
4 years, 4 months ago (2016-07-26 23:33:47 UTC) #58
sky
I still would prefer you break this up. If not, it will take longer to ...
4 years, 4 months ago (2016-07-26 23:47:50 UTC) #59
afakhry
On 2016/07/26 23:47:50, sky wrote: > I still would prefer you break this up. If ...
4 years, 4 months ago (2016-07-27 00:46:08 UTC) #62
sky
On Tue, Jul 26, 2016 at 5:46 PM, <afakhry@chromium.org> wrote: > On 2016/07/26 23:47:50, sky ...
4 years, 4 months ago (2016-07-27 15:08:07 UTC) #63
sky
https://codereview.chromium.org/2107493002/diff/360001/sql/connection.h File sql/connection.h (right): https://codereview.chromium.org/2107493002/diff/360001/sql/connection.h#newcode244 sql/connection.h:244: std::string GetDiagnosticInfo(int extended_error, Statement* statement); Is there a reason ...
4 years, 4 months ago (2016-07-27 15:12:56 UTC) #64
afakhry
Re "the user might want to nuke the DB file": We actually do that when ...
4 years, 4 months ago (2016-07-27 18:53:55 UTC) #65
afakhry
sky: Friendly ping?
4 years, 4 months ago (2016-08-01 21:25:00 UTC) #70
sky
https://codereview.chromium.org/2107493002/diff/380001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2107493002/diff/380001/chrome/app/generated_resources.grd#newcode11441 chrome/app/generated_resources.grd:11441: +Tell us what happened exactly before you got the ...
4 years, 4 months ago (2016-08-02 13:27:21 UTC) #71
afakhry
https://codereview.chromium.org/2107493002/diff/380001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2107493002/diff/380001/chrome/app/generated_resources.grd#newcode11441 chrome/app/generated_resources.grd:11441: +Tell us what happened exactly before you got the ...
4 years, 4 months ago (2016-08-02 23:58:25 UTC) #74
sky
https://codereview.chromium.org/2107493002/diff/380001/components/history/core/browser/history_backend.cc File components/history/core/browser/history_backend.cc (right): https://codereview.chromium.org/2107493002/diff/380001/components/history/core/browser/history_backend.cc#newcode674 components/history/core/browser/history_backend.cc:674: const std::string corrupted_file_name = On 2016/08/02 23:58:24, afakhry wrote: ...
4 years, 4 months ago (2016-08-03 15:19:30 UTC) #77
afakhry
https://codereview.chromium.org/2107493002/diff/380001/components/history/core/browser/history_backend.cc File components/history/core/browser/history_backend.cc (right): https://codereview.chromium.org/2107493002/diff/380001/components/history/core/browser/history_backend.cc#newcode674 components/history/core/browser/history_backend.cc:674: const std::string corrupted_file_name = On 2016/08/03 15:19:30, sky wrote: ...
4 years, 4 months ago (2016-08-03 17:51:23 UTC) #79
sky
https://codereview.chromium.org/2107493002/diff/420001/sql/error_delegate_util.h File sql/error_delegate_util.h (right): https://codereview.chromium.org/2107493002/diff/420001/sql/error_delegate_util.h#newcode25 sql/error_delegate_util.h:25: SQL_EXPORT void AppendCorruptFileInfoToDiagnostics( Sorry, one question, can you clarify ...
4 years, 4 months ago (2016-08-03 23:36:19 UTC) #83
afakhry
https://codereview.chromium.org/2107493002/diff/420001/sql/error_delegate_util.h File sql/error_delegate_util.h (right): https://codereview.chromium.org/2107493002/diff/420001/sql/error_delegate_util.h#newcode25 sql/error_delegate_util.h:25: SQL_EXPORT void AppendCorruptFileInfoToDiagnostics( On 2016/08/03 23:36:18, sky wrote: > ...
4 years, 4 months ago (2016-08-04 18:01:31 UTC) #84
sky
Thanks, LGTM
4 years, 4 months ago (2016-08-04 20:19:21 UTC) #89
afakhry
pkasting@ For components/webdata
4 years, 4 months ago (2016-08-04 20:40:09 UTC) #93
afakhry
droger@chromium.org: Please review changes in ios/
4 years, 4 months ago (2016-08-04 20:42:36 UTC) #95
sdefresne
ios/ lgtm
4 years, 4 months ago (2016-08-04 20:45:07 UTC) #97
afakhry
gbillock@ PATL at sql/
4 years, 4 months ago (2016-08-04 21:07:24 UTC) #99
Peter Kasting
LGTM https://codereview.chromium.org/2107493002/diff/440001/components/webdata/common/web_database_backend.cc File components/webdata/common/web_database_backend.cc (right): https://codereview.chromium.org/2107493002/diff/440001/components/webdata/common/web_database_backend.cc#newcode62 components/webdata/common/web_database_backend.cc:62: db_diagnostics_ += sql::GetCorruptFileDiagnosticsInfo(db_path_); We don't need to add ...
4 years, 4 months ago (2016-08-05 00:20:45 UTC) #100
Greg Billock
On 2016/08/05 00:20:45, Peter Kasting wrote: > LGTM > > https://codereview.chromium.org/2107493002/diff/440001/components/webdata/common/web_database_backend.cc > File components/webdata/common/web_database_backend.cc (right): ...
4 years, 4 months ago (2016-08-05 03:38:21 UTC) #101
droger
ios lgtm https://codereview.chromium.org/2107493002/diff/440001/ios/chrome/browser/web_data_service_factory.cc File ios/chrome/browser/web_data_service_factory.cc (right): https://codereview.chromium.org/2107493002/diff/440001/ios/chrome/browser/web_data_service_factory.cc#newcode29 ios/chrome/browser/web_data_service_factory.cc:29: const std::string&) {} Tiny nit: the 3rd ...
4 years, 4 months ago (2016-08-05 08:44:12 UTC) #102
afakhry
https://codereview.chromium.org/2107493002/diff/440001/components/webdata/common/web_database_backend.cc File components/webdata/common/web_database_backend.cc (right): https://codereview.chromium.org/2107493002/diff/440001/components/webdata/common/web_database_backend.cc#newcode62 components/webdata/common/web_database_backend.cc:62: db_diagnostics_ += sql::GetCorruptFileDiagnosticsInfo(db_path_); On 2016/08/05 00:20:44, Peter Kasting wrote: ...
4 years, 4 months ago (2016-08-05 16:13:22 UTC) #105
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107493002/460001
4 years, 4 months ago (2016-08-05 16:49:10 UTC) #110
commit-bot: I haz the power
Committed patchset #22 (id:460001)
4 years, 4 months ago (2016-08-05 17:33:37 UTC) #112
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 17:35:39 UTC) #114
Message was sent while issue was closed.
Patchset 22 (id:??) landed as
https://crrev.com/7c9abe71bce004b6b3af1cef691f7ca8a455e56b
Cr-Commit-Position: refs/heads/master@{#410094}

Powered by Google App Engine
This is Rietveld 408576698