Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/browser/ui/profile_error_dialog.h

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Yet more compile errors Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
6 #define CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 6 #define CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
7 7
8 #include "sql/db_diagnostic_map.h"
9 #include "sql/init_status.h"
Lei Zhang 2016/07/09 01:04:47 Not needed here?
afakhry 2016/07/11 16:47:45 Done.
10
11 namespace base {
12 class FilePath;
Lei Zhang 2016/07/09 01:04:47 Not needed?
afakhry 2016/07/11 16:47:45 Yup, forgot to remove it. Done.
13 } // namespace base
14
8 // Be very careful while modifying this enum. Do NOT remove any elements from 15 // Be very careful while modifying this enum. Do NOT remove any elements from
9 // this enum. If you need to add one, add them to the end, right before 16 // this enum. If you need to add one, add them to the end, right before
10 // PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element in 17 // PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element in
11 // this enum. This is important because this enum is used to back a histogram, 18 // this enum. This is important because this enum is used to back a histogram,
12 // and these are implicit assumptions made in terms of how enumerated 19 // and these are implicit assumptions made in terms of how enumerated
13 // histograms are defined. 20 // histograms are defined.
14 enum ProfileErrorType { 21 enum ProfileErrorType {
15 PROFILE_ERROR_HISTORY, 22 PROFILE_ERROR_HISTORY,
16 PROFILE_ERROR_PREFERENCES, 23 PROFILE_ERROR_PREFERENCES,
17 PROFILE_ERROR_DB_AUTOFILL_WEB_DATA, 24 PROFILE_ERROR_DB_AUTOFILL_WEB_DATA,
18 PROFILE_ERROR_DB_TOKEN_WEB_DATA, 25 PROFILE_ERROR_DB_TOKEN_WEB_DATA,
19 PROFILE_ERROR_DB_WEB_DATA, 26 PROFILE_ERROR_DB_WEB_DATA,
20 PROFILE_ERROR_DB_KEYWORD_WEB_DATA, 27 PROFILE_ERROR_DB_KEYWORD_WEB_DATA,
21 PROFILE_ERROR_END 28 PROFILE_ERROR_END
22 }; 29 };
23 30
24 // Shows an error dialog corresponding to the inability to open some portion of 31 // Shows an error dialog corresponding to the inability to open some portion of
25 // the profile. |message_id| is a string id corresponding to the message to 32 // the profile. |diagnostics| contains diagnostic information about the database
Lei Zhang 2016/07/09 01:04:47 Maybe start a new line for each param. It's a long
afakhry 2016/07/11 16:47:45 Done.
26 // show. The ProfileErrorType needs to correspond to one of the profile error 33 // file that might have caused a profile error. |message_id| is a string id
27 // types in the enum above. If your use case doesn't fit any of the ones listed 34 // corresponding to the message to show. The ProfileErrorType needs to
28 // above, please add your type to the enum and modify the enum 35 // correspond to one of the profile error types in the enum above. If your use
29 // definition in tools/metrics/histograms/histograms.xml accordingly. 36 // case doesn't fit any of the ones listed above, please add your type to the
30 void ShowProfileErrorDialog(ProfileErrorType type, int message_id); 37 // enum and modify the enum definition in
38 // tools/metrics/histograms/histograms.xml accordingly.
39 void ShowProfileErrorDialog(ProfileErrorType type,
40 int message_id,
41 const sql::DatabaseDiagnosticMap& diagnostics);
31 42
32 #endif // CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 43 #endif // CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698