Offer user to send feedback from profile error dialog

components/history/core/browser/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <functional>
 #include <list>
 #include <map>
@@ skipping 639 matching lines @@
 
   // Unretained to avoid a ref loop with db_.
   db_->set_error_callback(base::Bind(&HistoryBackend::DatabaseErrorCallback,
                                      base::Unretained(this)));
 
   sql::InitStatus status = db_->Init(history_name);
   switch (status) {
     case sql::INIT_OK:
       break;
     case sql::INIT_TOO_NEW:
-      delegate_->NotifyProfileError(status);
+      delegate_->NotifyProfileError(history_name, status);
       db_.reset();
       return;
     case sql::INIT_FAILURE: {
       // A null db_ will cause all calls on this object to notice this error
       // and to not continue. If the error callback scheduled killing the
       // database, the task it posted has not executed yet. Try killing the
       // database now before we close it.
       bool kill_db = scheduled_kill_db_;
       if (kill_db)
         KillHistoryDatabase();
       UMA_HISTOGRAM_BOOLEAN("History.AttemptedToFixProfileError", kill_db);
-      delegate_->NotifyProfileError(status);
+      delegate_->NotifyProfileError(history_name, status);

[Scott Hess - ex-Googler, 2016/06/29 05:13:48]

Note that if the db is open, it may hold locks which will prevent a generic
diagnostic from working.  Likewise above.

[afakhry, 2016/06/29 18:57:18]

So do you suggest moving these calls elsewhere? Perhaps after the DB has been
killed?

[Scott Hess - ex-Googler, 2016/06/29 19:17:27]

Depends on what you're going to do.  If NotifyProfileError() needs to run before
reset() on the next line, and NotifyProfileError() might want to open the
database to inspect it, then you need to explicitly call Close().  But if it's
going to be entirely independent with no way to refer back to this code, then
you could just put the reset() above the notify call.

       db_.reset();
       return;
     }
     default:
       NOTREACHED();
   }
 
   // Fill the in-memory database and send it back to the history service on the
   // main thread.
   {
@@ skipping 1940 matching lines @@
   // transaction is currently open.
   db_->CommitTransaction();
   db_->Vacuum();
   db_->BeginTransaction();
   db_->GetStartDate(&first_recorded_time_);
 
   return true;
 }
 
 }  // namespace history