Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: components/webdata/common/web_database_service.cc

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pkasting's & droger's Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/webdata/common/web_database_service.cc
diff --git a/components/webdata/common/web_database_service.cc b/components/webdata/common/web_database_service.cc
index 3ecd6f3ac6c1dda0d70137b818693255f1884b94..a5ed8633b2f705ba2a83c7c2f73b87591a3a2b4f 100644
--- a/components/webdata/common/web_database_service.cc
+++ b/components/webdata/common/web_database_service.cc
@@ -27,12 +27,11 @@ class WebDatabaseService::BackendDelegate
: web_database_service_(web_database_service),
callback_thread_(base::ThreadTaskRunnerHandle::Get()) {}
- void DBLoaded(sql::InitStatus status) override {
+ void DBLoaded(sql::InitStatus status,
+ const std::string& diagnostics) override {
callback_thread_->PostTask(
- FROM_HERE,
- base::Bind(&WebDatabaseService::OnDatabaseLoadDone,
- web_database_service_,
- status));
+ FROM_HERE, base::Bind(&WebDatabaseService::OnDatabaseLoadDone,
+ web_database_service_, status, diagnostics));
}
private:
const base::WeakPtr<WebDatabaseService> web_database_service_;
@@ -133,21 +132,22 @@ void WebDatabaseService::RegisterDBErrorCallback(
error_callbacks_.push_back(callback);
}
-void WebDatabaseService::OnDatabaseLoadDone(sql::InitStatus status) {
+void WebDatabaseService::OnDatabaseLoadDone(sql::InitStatus status,
+ const std::string& diagnostics) {
if (status == sql::INIT_OK) {
db_loaded_ = true;
- for (size_t i = 0; i < loaded_callbacks_.size(); i++) {
- if (!loaded_callbacks_[i].is_null())
- loaded_callbacks_[i].Run();
+ for (const auto& loaded_callback : loaded_callbacks_) {
+ if (!loaded_callback.is_null())
+ loaded_callback.Run();
}
loaded_callbacks_.clear();
} else {
// Notify that the database load failed.
- for (size_t i = 0; i < error_callbacks_.size(); i++) {
- if (!error_callbacks_[i].is_null())
- error_callbacks_[i].Run(status);
+ for (const auto& error_callback : error_callbacks_) {
+ if (!error_callback.is_null())
+ error_callback.Run(status, diagnostics);
}
error_callbacks_.clear();
« no previous file with comments | « components/webdata/common/web_database_service.h ('k') | components/webdata_services/web_data_service_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698