Offer user to send feedback from profile error dialog

components/webdata/common/web_database_backend.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_BACKEND_H_
 #define COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_BACKEND_H_
 
 #include <memory>
 
 #include "base/callback_forward.h"
@@ skipping 21 matching lines @@
 // DB thread.
 
 class WEBDATA_EXPORT WebDatabaseBackend
     : public base::RefCountedDeleteOnMessageLoop<WebDatabaseBackend> {
  public:
   class Delegate {
    public:
     virtual ~Delegate() {}
 
     // Invoked when the backend has finished loading the db.
-    virtual void DBLoaded(sql::InitStatus status) = 0;
+    // |status| is the result of initializing the db.
+    // |diagnostics| contains diagnostic information about the db, and it will
+    // only be populated when an error occurs.
+    virtual void DBLoaded(sql::InitStatus status,
+                          const std::string& diagnostics) = 0;
   };
 
   WebDatabaseBackend(
       const base::FilePath& path,
       Delegate* delegate,
       const scoped_refptr<base::SingleThreadTaskRunner>& db_thread);
 
   // Must call only before InitDatabaseWithCallback.
   void AddTable(std::unique_ptr<WebDatabaseTable> table);
 
@@ skipping 30 matching lines @@
 
   WebDatabase* database() { return db_.get(); }
 
  protected:
   friend class base::RefCountedDeleteOnMessageLoop<WebDatabaseBackend>;
   friend class base::DeleteHelper<WebDatabaseBackend>;
 
   virtual ~WebDatabaseBackend();
 
  private:
+  // Invoked on a db error.
+  void DatabaseErrorCallback(int error, sql::Statement* stmt);

[Peter Kasting, 2016/08/05 00:20:45]

Nit: Prefer to spell out "statement" rather than abbreviate

[afakhry, 2016/08/05 16:13:22]

Done.

+
   // Commit the current transaction.
   void Commit();
 
   // Path to database file.
   base::FilePath db_path_;
 
   // The tables that participate in managing the database. These are
   // owned here but other than that this class does nothing with
   // them. Their initialization is in whatever factory creates
   // WebDatabaseService, and lookup by type is provided by the
   // WebDatabase class. The tables need to be owned by this refcounted
   // object, or they themselves would need to be refcounted. Owning
   // them here rather than having WebDatabase own them makes for
   // easier unit testing of WebDatabase.
   ScopedVector<WebDatabaseTable> tables_;
 
   std::unique_ptr<WebDatabase> db_;
 
   // Keeps track of all pending requests made to the db.
   scoped_refptr<WebDataRequestManager> request_manager_;
 
   // State of database initialization. Used to prevent the executing of tasks
   // before the db is ready.
   sql::InitStatus init_status_;
 
+  // Contains diagnostic information about the database that is non-empty when
+  // a catastrophic error occurs.

[Peter Kasting, 2016/08/05 00:20:45]

Nit: Confusing antecedent; how about "If a catastrophic database error has
occurred, this contains any available diagnostic information."?

[afakhry, 2016/08/05 16:13:22]

Done.

+  std::string db_diagnostics_;

[Peter Kasting, 2016/08/05 00:20:45]

Nit: Dunno that the "db_" part of this is really necessary

[afakhry, 2016/08/05 16:13:22]

Done.

+
   // True if an attempt has been made to load the database (even if the attempt
   // fails), used to avoid continually trying to reinit if the db init fails.
   bool init_complete_;
 
+  // True if a catastrophic database error occurs and further error callbacks
+  // from the database should be ignored.

[Peter Kasting, 2016/08/05 00:20:44]

Since both this comment and the one above talk about "when a catastrophic error
occurs", should this variable be something more like
|catastrophic_error_occurred_|?  Then it would be clear that the string above is
only valid when this is true (and I would even move that string definition down
to just below this bool).

[afakhry, 2016/08/05 16:13:22]

Done.

+  bool should_ignore_db_errors_;
+
   // Delegate. See the class definition above for more information.
   std::unique_ptr<Delegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(WebDatabaseBackend);
 };
 
 #endif  // COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_BACKEND_H_