CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org

Committed: https://crrev.com/a38381ed776183a241a22de7344e92a5d09aa4bd
Cr-Commit-Position: refs/heads/master@{#402672}

[Ian Wen, 2016-06-29 00:20:30]

PTAL

[Ted C, 2016-06-29 00:29:04]

lgtm w/ updated comment to include cct changes

[Ian Wen, 2016-06-29 00:34:14]

Description was changed from

==========
[Android] Introduce CancelAwareAnimatorListner to Chrome

OnAnimationCancel() and OnAnimationEnd() will both be called if
Animator is canclled. This is a confusing behavior and it caused
problems in various places.

This CL proposes a custom animator listener that will distinguish onEnd
and onCancel. Also it changes the way security icon animation works in
custom tab.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org
==========

to

==========
CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org
==========

[Ian Wen, 2016-06-29 00:34:44]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2016-06-29 00:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:26:17]

Description was changed from

==========
CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org
==========

to

==========
CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 02:26:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 02:28:15]

Description was changed from

==========
CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org
==========

to

==========
CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org

Committed: https://crrev.com/a38381ed776183a241a22de7344e92a5d09aa4bd
Cr-Commit-Position: refs/heads/master@{#402672}
==========

[commit-bot: I haz the power, 2016-06-29 02:28:17]

Patchset 1 (id:??) landed as
https://crrev.com/a38381ed776183a241a22de7344e92a5d09aa4bd
Cr-Commit-Position: refs/heads/master@{#402672}