Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 03e83288013e7f35c0abc07a65d1f0b3af9d37e7..fde1759f6e09f9f61c099828d247f5cbc633b488 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -90,6 +90,7 @@ import org.chromium.chrome.browser.util.KeyNavigationUtil;
import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.chrome.browser.widget.animation.AnimatorProperties;
+import org.chromium.chrome.browser.widget.animation.CancelAwareAnimatorListener;
import org.chromium.components.security_state.ConnectionSecurityLevel;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.WebContents;
@@ -2209,22 +2210,9 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
mFadeOutOmniboxBackgroundAnimator.setDuration(OMNIBOX_CONTAINER_BACKGROUND_FADE_MS);
mFadeOutOmniboxBackgroundAnimator.setInterpolator(
BakedBezierInterpolator.FADE_OUT_CURVE);
- mFadeOutOmniboxBackgroundAnimator.addListener(new AnimatorListenerAdapter() {
- private boolean mIsCancelled;
-
- @Override
- public void onAnimationStart(Animator animation) {
- mIsCancelled = false;
- }
-
- @Override
- public void onAnimationCancel(Animator animation) {
- mIsCancelled = true;
- }
-
+ mFadeOutOmniboxBackgroundAnimator.addListener(new CancelAwareAnimatorListener() {
@Override
- public void onAnimationEnd(Animator animation) {
- if (mIsCancelled) return;
+ public void onEnd(Animator animator) {
updateOmniboxResultsContainerVisibility(false);
}
});

Powered by Google App Engine
This is Rietveld 408576698