chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java - Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

index 2a2dbbd38b5c1585250cebd4d6cada1dc1fa3af6..3432348820927907260a322bfcfa4ca777a6ad1c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

@@ -387,11 +387,7 @@ public class LocationBarPhone extends LocationBarLayout {

@Override

public void onAnimationEnd(Animator animation) {

- mIsMenuBadgeAnimationRunning = false;

- }

- @Override

- public void onAnimationCancel(Animator animation) {

+ // animator#cancel() will trigger onAnimationEnd() as well.

mIsMenuBadgeAnimationRunning = false;

}

});