chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java - Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/custom_tabs_toolbar.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

index 143d95928144b6d3a64230b90a4e9aca00907b9f..919a1d243b767a962b0c94c84f5dcf9ff5385120 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java

@@ -5,7 +5,7 @@

package org.chromium.chrome.browser.ntp.snippets;

import android.animation.Animator;

-import android.animation.Animator.AnimatorListener;

+import android.animation.AnimatorListenerAdapter;

import android.animation.ObjectAnimator;

import android.support.v7.widget.RecyclerView;

import android.view.LayoutInflater;

@@ -92,17 +92,11 @@ public class SnippetHeaderViewHolder extends NewTabPageViewHolder {

mAnimator = ObjectAnimator.ofFloat(itemView, View.ALPHA, currentAlpha, targetAlpha);

mAnimator.setDuration(ANIMATION_DURATION_MS);

- mAnimator.addListener(new AnimatorListener() {

- @Override

- public void onAnimationStart(Animator animator) {}

- @Override

- public void onAnimationRepeat(Animator animator) {}

+ mAnimator.addListener(new AnimatorListenerAdapter() {

@Override

public void onAnimationEnd(Animator animator) {

mAnimator = null;

}

- @Override

- public void onAnimationCancel(Animator animator) {}

});

mAnimator.start();

}