Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java

Issue 2104053005: CancelAwareAnimatorListener and Refactor Custom Tab Toolbar Animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
index 4448e36dc091b0893e9aaae54e515055205a9cd6..c88cf6f7bba7f2031e9b45dde80f60851e1e786a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
@@ -20,6 +20,7 @@ import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.toolbar.ToolbarTablet;
+import org.chromium.chrome.browser.widget.animation.CancelAwareAnimatorListener;
import org.chromium.ui.UiUtils;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.interpolators.BakedBezierInterpolator;
@@ -188,21 +189,15 @@ public class LocationBarTablet extends LocationBarLayout {
ObjectAnimator.ofFloat(this, mUrlFocusChangePercentProperty, hasFocus ? 1f : 0f);
mUrlFocusChangeAnimator.setDuration(
(long) (MAX_NTP_KEYBOARD_FOCUS_DURATION_MS * screenSizeRatio));
- mUrlFocusChangeAnimator.addListener(new AnimatorListenerAdapter() {
- private boolean mIsCancelled;
-
+ mUrlFocusChangeAnimator.addListener(new CancelAwareAnimatorListener() {
@Override
- public void onAnimationCancel(Animator animation) {
- mIsCancelled = true;
+ public void onEnd(Animator animator) {
+ finishUrlFocusChange(hasFocus);
}
@Override
- public void onAnimationEnd(Animator animation) {
- if (mIsCancelled) {
- setUrlFocusChangeInProgress(false);
- return;
- }
- finishUrlFocusChange(hasFocus);
+ public void onCancel(Animator animator) {
+ setUrlFocusChangeInProgress(false);
}
});
setUrlFocusChangeInProgress(true);

Powered by Google App Engine
This is Rietveld 408576698