Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2103043007: Rename AbstractAudioContext to BaseAudioContext (Closed)

Created:
4 years, 5 months ago by Raymond Toy
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AbstractAudioContext to BaseAudioContext A mostly mechanical change renaming AbstractAudioContext to BaseAudioContext to match the class names used in the WebAudio spec. This is a first step in actually implementing the BaseAudioContext class as required. The change is done using for f in *.cpp *.h do sed -i 's/AbstractAudioContext/BaseAudioContext/g' $f done And manually updating AudioContext.idl and renaming AbstractAudioContext.* to BaseAudioContext.*, and ordering the include files correctly. BUG=624602 TEST= Committed: https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943 Cr-Commit-Position: refs/heads/master@{#404234}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Alphabetical order. #

Patch Set 4 : Fix presubmit warnings on ASSERT. #

Patch Set 5 : Use ASSERT(isGraphOwner()) instead of DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -1621 lines) Patch
M third_party/WebKit/Source/modules/modules.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h View 1 chunk +0 lines, -382 lines 0 comments Download
D third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 1 chunk +0 lines, -840 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AnalyserNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 20 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioSourceNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h View 1 2 3 7 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 1 2 3 4 29 chunks +116 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DelayNode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DelayNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/GainNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/GainNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 2 3 10 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/StereoPannerNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/StereoPannerNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Raymond Toy
PTAL. +dominicc: FYI since you did the original split of the context into two. This ...
4 years, 5 months ago (2016-06-30 15:40:32 UTC) #4
dominicc (has gone to gerrit)
LGTM modulo one nit about order inline. https://codereview.chromium.org/2103043007/diff/1/third_party/WebKit/Source/modules/modules.gypi File third_party/WebKit/Source/modules/modules.gypi (right): https://codereview.chromium.org/2103043007/diff/1/third_party/WebKit/Source/modules/modules.gypi#newcode1636 third_party/WebKit/Source/modules/modules.gypi:1636: 'webaudio/BaseAudioContext.cpp', Keep ...
4 years, 5 months ago (2016-07-04 00:10:38 UTC) #5
Raymond Toy
https://codereview.chromium.org/2103043007/diff/1/third_party/WebKit/Source/modules/modules.gypi File third_party/WebKit/Source/modules/modules.gypi (right): https://codereview.chromium.org/2103043007/diff/1/third_party/WebKit/Source/modules/modules.gypi#newcode1636 third_party/WebKit/Source/modules/modules.gypi:1636: 'webaudio/BaseAudioContext.cpp', On 2016/07/04 00:10:38, dominicc wrote: > Keep these ...
4 years, 5 months ago (2016-07-07 16:24:10 UTC) #6
hongchan
lgtm
4 years, 5 months ago (2016-07-07 17:28:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103043007/80001
4 years, 5 months ago (2016-07-07 17:33:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/241358)
4 years, 5 months ago (2016-07-07 18:35:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103043007/80001
4 years, 5 months ago (2016-07-07 19:43:37 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-07 20:29:42 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 20:29:57 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 20:31:26 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f42bd09051cdcbb26dda15097971ea3843d68943
Cr-Commit-Position: refs/heads/master@{#404234}

Powered by Google App Engine
This is Rietveld 408576698