gl_bindings: add support for more extensions

gl_bindings: add support for more extensions

Namely:
 - GL_EXT_transform_feedback
 - GL_ARB_transform_feedback2
 - GL_ARB_sampler_objects

These extensions are needed to support OpenGL ES 3 level functionality
on a Core OpenGL 3.3 Intel Mesa context.

BUG=598902
Committed: https://crrev.com/112bc8b288d9af60b3760dd919651f6393fd161e
Cr-Commit-Position: refs/heads/master@{#402192}

[Corentin Wallez, 2016-06-24 20:09:11]

cwallez@chromium.org changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-06-24 20:09:12]

PTAL: needed by https://codereview.chromium.org/2098913002 otherwise some
entry-points don't get loaded and result in a crash.

[piman, 2016-06-24 21:33:35]

lgtm

[Zhenyao Mo, 2016-06-24 21:38:33]

lgtm with nits

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py
File ui/gl/generate_bindings.py (right):

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:68: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:79: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:84: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:435: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:733: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:1137: 'extension': ['GL_EXT_transform_feedback'] }],
nit: wrong indent.

[Corentin Wallez, 2016-06-27 15:10:30]

Thanks for the review!

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py
File ui/gl/generate_bindings.py (right):

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:68: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:79: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:84: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:435: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:733: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#...
ui/gl/generate_bindings.py:1137: 'extension': ['GL_EXT_transform_feedback'] }],
On 2016/06/24 at 21:38:33, Zhenyao Mo wrote:
> nit: wrong indent.

done

[Corentin Wallez, 2016-06-27 15:10:55]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-06-27 15:10:55]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2099503003/#ps20001
(title: "Address nits")

[commit-bot: I haz the power, 2016-06-27 15:11:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:10:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 16:12:34]

Description was changed from

==========
gl_bindings: add support for more extensions

Namely:
 - GL_EXT_transform_feedback
 - GL_ARB_transform_feedback2
 - GL_ARB_sampler_objects

These extensions are needed to support OpenGL ES 3 level functionality
on a Core OpenGL 3.3 Intel Mesa context.

BUG=598902
==========

to

==========
gl_bindings: add support for more extensions

Namely:
 - GL_EXT_transform_feedback
 - GL_ARB_transform_feedback2
 - GL_ARB_sampler_objects

These extensions are needed to support OpenGL ES 3 level functionality
on a Core OpenGL 3.3 Intel Mesa context.

BUG=598902

Committed: https://crrev.com/112bc8b288d9af60b3760dd919651f6393fd161e
Cr-Commit-Position: refs/heads/master@{#402192}
==========

[commit-bot: I haz the power, 2016-06-27 16:12:35]

Patchset 2 (id:??) landed as
https://crrev.com/112bc8b288d9af60b3760dd919651f6393fd161e
Cr-Commit-Position: refs/heads/master@{#402192}