Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2099503003: gl_bindings: add support for more extensions (Closed)

Created:
4 years, 6 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_bindings: add support for more extensions Namely: - GL_EXT_transform_feedback - GL_ARB_transform_feedback2 - GL_ARB_sampler_objects These extensions are needed to support OpenGL ES 3 level functionality on a Core OpenGL 3.3 Intel Mesa context. BUG=598902 Committed: https://crrev.com/112bc8b288d9af60b3760dd919651f6393fd161e Cr-Commit-Position: refs/heads/master@{#402192}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -38 lines) Patch
M ui/gl/generate_bindings.py View 1 14 chunks +50 lines, -22 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 16 chunks +59 lines, -16 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 5 chunks +24 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 10 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Corentin Wallez
PTAL: needed by https://codereview.chromium.org/2098913002 otherwise some entry-points don't get loaded and result in a crash.
4 years, 6 months ago (2016-06-24 20:09:12 UTC) #2
piman
lgtm
4 years, 6 months ago (2016-06-24 21:33:35 UTC) #3
Zhenyao Mo
lgtm with nits https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py File ui/gl/generate_bindings.py (right): https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#newcode68 ui/gl/generate_bindings.py:68: 'extension': ['GL_EXT_transform_feedback'] }], nit: wrong indent. ...
4 years, 6 months ago (2016-06-24 21:38:33 UTC) #4
Corentin Wallez
Thanks for the review! https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py File ui/gl/generate_bindings.py (right): https://codereview.chromium.org/2099503003/diff/1/ui/gl/generate_bindings.py#newcode68 ui/gl/generate_bindings.py:68: 'extension': ['GL_EXT_transform_feedback'] }], On 2016/06/24 ...
4 years, 5 months ago (2016-06-27 15:10:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099503003/20001
4 years, 5 months ago (2016-06-27 15:11:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 16:10:38 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:12:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/112bc8b288d9af60b3760dd919651f6393fd161e
Cr-Commit-Position: refs/heads/master@{#402192}

Powered by Google App Engine
This is Rietveld 408576698