GLVersionInfo: alse detect es3 support with extensions

GLVersionInfo: also detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3b2dfed0881cfaf4e4181ee38ac9c01a5baba52b
Cr-Commit-Position: refs/heads/master@{#402263}

[Corentin Wallez, 2016-06-24 20:07:34]

Description was changed from

==========
GLVersionInfo: alse detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
==========

to

==========
GLVersionInfo: alse detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-06-24 20:10:10]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-06-24 20:10:11]

PTAL, this allows creation of OpenGL ES 3 contexts on the Mesa 3.3 contexts.

[Zhenyao Mo, 2016-06-24 21:35:50]

lgtm with nits

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:101: // TODO(cwallez) check for texture related
extensions.
Please create a bug so we don't end up forgetting about this. Reference the bug
ID here.

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.h
File ui/gl/gl_version_info.h (right):

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.h#new...
ui/gl/gl_version_info.h:42: bool IsES3Capable(std::set<std::string>& extensions)
const;
Delete this.

[piman, 2016-06-24 21:38:56]

LGTM % nits

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:74: auto hasExtension = [&extensions](std::string
extension) -> bool {
nit: has_extension

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:89: bool hasShaderPacking = IsAtLeastGL(4, 2) ||
nit: has_shader_packing

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:89: bool hasShaderPacking = IsAtLeastGL(4, 2) ||
nit: we already did early out if IsAtLeastGL(4, 2) was true, so this one is
always false here. You can remove it.

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:92: bool hasTransformFeedback =
nit: has_transform_feedback

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:94: bool hasSamplers = IsAtLeastGL(3, 3) ||
hasExtension("GL_ARB_sampler_object");
nit: has_samplers

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:95: bool hasSwizzle = IsAtLeastGL(3, 3) ||
nit: has_swizzle

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:98: bool hasAttribLocation =
nit: has_attrib_location

[Ken Russell (switch to Gerrit), 2016-06-24 22:48:17]

lgtm with zmo's and piman's comments addressed.

[Corentin Wallez, 2016-06-27 15:35:42]

Thanks for the review.

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:74: auto hasExtension = [&extensions](std::string
extension) -> bool {
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_extension

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:89: bool hasShaderPacking = IsAtLeastGL(4, 2) ||
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_shader_packing

Done (both)

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:92: bool hasTransformFeedback =
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_transform_feedback

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:94: bool hasSamplers = IsAtLeastGL(3, 3) ||
hasExtension("GL_ARB_sampler_object");
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_samplers

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:95: bool hasSwizzle = IsAtLeastGL(3, 3) ||
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_swizzle

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:98: bool hasAttribLocation =
On 2016/06/24 at 21:38:56, piman wrote:
> nit: has_attrib_location

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.cc#ne...
ui/gl/gl_version_info.cc:101: // TODO(cwallez) check for texture related
extensions.
On 2016/06/24 at 21:35:50, Zhenyao Mo wrote:
> Please create a bug so we don't end up forgetting about this. Reference the
bug ID here.

Done

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.h
File ui/gl/gl_version_info.h (right):

https://codereview.chromium.org/2098913002/diff/1/ui/gl/gl_version_info.h#new...
ui/gl/gl_version_info.h:42: bool IsES3Capable(std::set<std::string>& extensions)
const;
On 2016/06/24 at 21:35:50, Zhenyao Mo wrote:
> Delete this.

Done

[Corentin Wallez, 2016-06-27 17:22:15]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-06-27 17:22:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2098913002/#ps20001
(title: "Address comments")

[Corentin Wallez, 2016-06-27 17:22:29]

The CQ bit was unchecked by cwallez@chromium.org

[Corentin Wallez, 2016-06-27 17:22:35]

Description was changed from

==========
GLVersionInfo: alse detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
GLVersionInfo: also detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-06-27 17:22:40]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:23:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 17:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:42:30]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Corentin Wallez, 2016-06-27 18:09:12]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-06-27 18:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2098913002/#ps40001
(title: "Fix references to IsES3Capable")

[commit-bot: I haz the power, 2016-06-27 18:10:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 20:03:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-27 20:05:34]

Description was changed from

==========
GLVersionInfo: also detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
GLVersionInfo: also detect es3 support with extensions

OpenGL ES 3 can be supported on desktop OpenGL before 4.2 provided the
right extensions are available. This allows ES3 to be supported on top
of the 11.2 Intel Mesa driver.

The logic in IsES3Capable was adapted from ANGLE's GenerateCaps function
in renderergl_utils.cpp.

BUG=598902
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3b2dfed0881cfaf4e4181ee38ac9c01a5baba52b
Cr-Commit-Position: refs/heads/master@{#402263}
==========

[commit-bot: I haz the power, 2016-06-27 20:05:35]

Patchset 3 (id:??) landed as
https://crrev.com/3b2dfed0881cfaf4e4181ee38ac9c01a5baba52b
Cr-Commit-Position: refs/heads/master@{#402263}