Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 209853004: Revert 258122 "gpu: Allow fences to check whether a flush has oc..." (Closed)

Created:
6 years, 9 months ago by no sievers
Modified:
6 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 258122 "gpu: Allow fences to check whether a flush has oc..." Seems to expose some GL call sites without current context. Reverting for the time being... BUG=355275 > gpu: Allow fences to check whether a flush has occurred > > This skips waiting on a fence that was created but never committed. > > BUG=352419 > > Review URL: https://codereview.chromium.org/197563003 TBR=sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -149 lines) Patch
M trunk/src/gpu/command_buffer/service/mailbox_manager_unittest.cc View 8 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/mailbox_synchronizer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/texture_definition.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/src/ui/gl/gl_context.h View 4 chunks +0 lines, -26 lines 0 comments Download
M trunk/src/ui/gl/gl_context.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M trunk/src/ui/gl/gl_fence.h View 1 chunk +1 line, -6 lines 0 comments Download
M trunk/src/ui/gl/gl_fence.cc View 8 chunks +12 lines, -47 lines 0 comments Download
M trunk/src/ui/gl/gl_gl_api_implementation.h View 3 chunks +1 line, -8 lines 0 comments Download
M trunk/src/ui/gl/gl_gl_api_implementation.cc View 3 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
no sievers
6 years, 9 months ago (2014-03-24 18:01:55 UTC) #1
no sievers
6 years, 9 months ago (2014-03-24 18:02:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r258965.

Powered by Google App Engine
This is Rietveld 408576698