net/quic/core/crypto/crypto_utils.cc - Issue 2097913002: Update QuicConnectionLogger to always log missing_packets, even for v34.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/crypto/crypto_utils.cc

Issue 2097913002: Update QuicConnectionLogger to always log missing_packets, even for v34. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test for domain names containing '_', in order to be more accepting of non-standard SNI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/crypto/crypto_utils.cc

diff --git a/net/quic/core/crypto/crypto_utils.cc b/net/quic/core/crypto/crypto_utils.cc

index b382339f47ec782397c73027391b3107658acf4a..87bc422452d9133f028aa9272e4834aaa389903f 100644

--- a/net/quic/core/crypto/crypto_utils.cc

+++ b/net/quic/core/crypto/crypto_utils.cc

@@ -54,11 +54,6 @@ void CryptoUtils::GenerateNonce(QuicWallTime now,

// static

bool CryptoUtils::IsValidSNI(StringPiece sni) {

- // TODO(rtenneti): Support RFC2396 hostname.

- // NOTE: Microsoft does NOT enforce this spec, so if we throw away hostnames

- // based on the above spec, we may be losing some hostnames that windows

- // would consider valid. By far the most common hostname character NOT

- // accepted by the above spec is '_'.

url::CanonHostInfo host_info;

string canonicalized_host(CanonicalizeHost(sni.as_string(), &host_info));

return !host_info.IsIPAddress() &&

« no previous file with comments | « no previous file | net/quic/core/crypto/crypto_utils_test.cc » ('j') | no next file with comments »