Update QuicConnectionLogger to always log missing_packets, even for v34.

net/quic/core/crypto/crypto_utils_test.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/crypto/crypto_utils.h"
 
 #include "net/quic/test_tools/quic_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using std::string;
 
 namespace net {
 namespace test {
 namespace {
 
 TEST(CryptoUtilsTest, IsValidSNI) {
   // IP as SNI.
   EXPECT_FALSE(CryptoUtils::IsValidSNI("192.168.0.1"));
   // SNI without any dot.
   EXPECT_FALSE(CryptoUtils::IsValidSNI("somedomain"));
-  // Invalid RFC2396 hostname
-  // TODO(rtenneti): Support RFC2396 hostname.
-  // EXPECT_FALSE(CryptoUtils::IsValidSNI("some_domain.com"));
+  // Invalid by RFC2396 but unfortunately domains of this form exist.
+  EXPECT_TRUE(CryptoUtils::IsValidSNI("some_domain.com"));
   // An empty string must be invalid otherwise the QUIC client will try sending
   // it.
   EXPECT_FALSE(CryptoUtils::IsValidSNI(""));
 
   // Valid SNI
   EXPECT_TRUE(CryptoUtils::IsValidSNI("test.google.com"));
 }
 
 TEST(CryptoUtilsTest, NormalizeHostname) {
   struct {
@@ skipping 152 matching lines @@
                CryptoUtils::HandshakeFailureReasonToString(MAX_FAILURE_REASON));
   EXPECT_STREQ(
       "INVALID_HANDSHAKE_FAILURE_REASON",
       CryptoUtils::HandshakeFailureReasonToString(
           static_cast<HandshakeFailureReason>(MAX_FAILURE_REASON + 1)));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net