Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2314863003: Fix all Performance and Bug-Prone patterns in quic/core. No functional change. Not flag protected. (Closed)

Created:
4 years, 3 months ago by ianswett
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix all Performance and Bug-Prone patterns in quic/core. No functional change. Not flag protected. This will probably have absolutely no impact on performance, but makes the ClangTidy layers in codesearch a lot less noisy. Merge internal change: 131588752 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M net/quic/core/congestion_control/send_algorithm_simulator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_promised_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/reliable_quic_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/chlo_extractor.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_per_connection_packet_writer.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ianswett
4 years, 3 months ago (2016-09-06 21:17:27 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-06 21:20:01 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698