Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2093873002: Unwind fallback metrics and SSLFailureState. (Closed)

Created:
4 years, 6 months ago by davidben
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unwind fallback metrics and SSLFailureState. Part 2 of removing the TLS version fallback code. These were of great help, but now that the fallback is dead and gone, we don't need them anymore. (Until it's time to bring back the fallback for TLS 1.3. :( But next time let's not require quite so much glue in net/http.) BUG=621780, 621754, 614110 TBR=asargent@chromium.org Committed: https://crrev.com/84936542b14d71b6c8f301b592263dcec0fb772e Cr-Commit-Position: refs/heads/master@{#401917}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -250 lines) Patch
M chrome/browser/extensions/api/socket/tls_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/bidirectional_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/http/bidirectional_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 3 chunks +1 line, -8 lines 0 comments Download
M net/http/http_network_transaction.cc View 5 chunks +2 lines, -70 lines 1 comment Download
M net/http/http_stream_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +1 line, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 6 chunks +12 lines, -16 lines 0 comments Download
M net/http/http_stream_factory_impl_request.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/http/http_stream_factory_test_util.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/client_socket_handle.h View 4 chunks +0 lines, -6 lines 0 comments Download
M net/socket/client_socket_handle.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/socket/fuzzed_socket_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/socket_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 5 chunks +0 lines, -32 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D net/ssl/ssl_failure_state.h View 1 chunk +0 lines, -49 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 6 chunks +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
davidben
rsleevi for general review mpearson for histograms https://codereview.chromium.org/2093873002/diff/1/net/http/http_network_transaction.cc File net/http/http_network_transaction.cc (left): https://codereview.chromium.org/2093873002/diff/1/net/http/http_network_transaction.cc#oldcode1640 net/http/http_network_transaction.cc:1640: server_ssl_config_.deprecated_cipher_suites_enabled); Left ...
4 years, 6 months ago (2016-06-24 00:33:29 UTC) #3
Ryan Sleevi
lgtm
4 years, 6 months ago (2016-06-24 00:41:38 UTC) #5
Mark P
histograms.xml lgtm
4 years, 6 months ago (2016-06-24 03:36:21 UTC) #6
davidben
TBR asargent for chrome/browser/extensions/api/socket/tls_socket_unittest.cc since it's a purely mechanical change.
4 years, 6 months ago (2016-06-24 17:30:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093873002/1
4 years, 6 months ago (2016-06-24 17:32:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 19:04:31 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 19:05:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84936542b14d71b6c8f301b592263dcec0fb772e
Cr-Commit-Position: refs/heads/master@{#401917}

Powered by Google App Engine
This is Rietveld 408576698