net/socket/ssl_client_socket_pool.cc - Issue 2093873002: Unwind fallback metrics and SSLFailureState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool.cc

Issue 2093873002: Unwind fallback metrics and SSLFailureState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_pool.cc

diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc

index 40c2ac6aa67ad9115b747d4a9f874971babb10af..a4b497d742c9646fa9dfdedbe5c6d91ca6d4c3f9 100644

--- a/net/socket/ssl_client_socket_pool.cc

+++ b/net/socket/ssl_client_socket_pool.cc

@@ -160,8 +160,6 @@ void SSLConnectJob::GetAdditionalErrorState(ClientSocketHandle* handle) {

handle->set_ssl_error_response_info(error_response_info_);

if (!connect_timing_.ssl_start.is_null())

handle->set_is_ssl_error(true);

- if (ssl_socket_)

- handle->set_ssl_failure_state(ssl_socket_->GetSSLFailureState());

handle->set_connection_attempts(connection_attempts_);

}