Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: net/http/http_network_transaction.h

Issue 2093873002: Unwind fallback metrics and SSLFailureState. (Closed) Base URL:
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction.h
diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h
index 001a30b8846a0d1a38d39f4f916605eb9bf17b95..bb606d837b27ae313ec498cfe1f64ca38ac83871 100644
--- a/net/http/http_network_transaction.h
+++ b/net/http/http_network_transaction.h
@@ -27,7 +27,6 @@
#include "net/socket/connection_attempts.h"
#include "net/ssl/channel_id_service.h"
#include "net/ssl/ssl_config_service.h"
-#include "net/ssl/ssl_failure_state.h"
#include "net/websockets/websocket_handshake_stream_base.h"
namespace crypto {
@@ -104,9 +103,7 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
const SSLConfig& used_ssl_config,
const ProxyInfo& used_proxy_info,
WebSocketHandshakeStreamBase* stream) override;
- void OnStreamFailed(int status,
- const SSLConfig& used_ssl_config,
- SSLFailureState ssl_failure_state) override;
+ void OnStreamFailed(int status, const SSLConfig& used_ssl_config) override;
void OnCertificateError(int status,
const SSLConfig& used_ssl_config,
const SSLInfo& ssl_info) override;
@@ -333,16 +330,12 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction
SSLConfig server_ssl_config_;
SSLConfig proxy_ssl_config_;
- // The SSLFailureState of the most recent failed stream.
- SSLFailureState server_ssl_failure_state_;
// fallback_error_code contains the error code that caused the last TLS
// fallback. If the fallback connection results in
// ERR_SSL_INAPPROPRIATE_FALLBACK (i.e. the server indicated that the
// fallback should not have been needed) then we use this value to return the
// original error that triggered the fallback.
int fallback_error_code_;
- // The SSLFailureState which caused the last TLS version fallback.
- SSLFailureState fallback_failure_state_;
// Keys to use for signing message in Token Binding header.
std::unique_ptr<crypto::ECPrivateKey> provided_token_binding_key_;

Powered by Google App Engine
This is Rietveld 408576698