Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2092543005: Stop passing --build-tool=ninja in master configs (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M masters/master.chromium.memory.fyi/master.cfg View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/master/factory/dart/dart_factory.py View 1 chunk +3 lines, -5 lines 1 comment Download
M scripts/master/factory/gclient_factory.py View 1 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Nico
https://codereview.chromium.org/2092543005/diff/20001/scripts/master/factory/dart/dart_factory.py File scripts/master/factory/dart/dart_factory.py (left): https://codereview.chromium.org/2092543005/diff/20001/scripts/master/factory/dart/dart_factory.py#oldcode335 scripts/master/factory/dart/dart_factory.py:335: mac_options = ['--compiler=goma-clang', goma-clang and goma mean the same ...
4 years, 6 months ago (2016-06-23 16:58:28 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-23 17:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092543005/20001
4 years, 6 months ago (2016-06-23 17:06:01 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:10:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/fdb3c016e913e8b9adb6...

Powered by Google App Engine
This is Rietveld 408576698