Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Utility classes to generate and manage a BuildFactory to be passed to a | 5 """Utility classes to generate and manage a BuildFactory to be passed to a |
| 6 builder dictionary as the 'factory' member, for each builder in c['builders']. | 6 builder dictionary as the 'factory' member, for each builder in c['builders']. |
| 7 | 7 |
| 8 Specifically creates a base BuildFactory that will execute a gclient checkout | 8 Specifically creates a base BuildFactory that will execute a gclient checkout |
| 9 first.""" | 9 first.""" |
| 10 | 10 |
| (...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 240 | 240 |
| 241 def BuildFactory(self, target='Release', clobber=False, tests=None, mode=None, | 241 def BuildFactory(self, target='Release', clobber=False, tests=None, mode=None, |
| 242 slave_type='BuilderTester', options=None, | 242 slave_type='BuilderTester', options=None, |
| 243 compile_timeout=1200, build_url=None, project=None, | 243 compile_timeout=1200, build_url=None, project=None, |
| 244 factory_properties=None, gclient_deps=None, | 244 factory_properties=None, gclient_deps=None, |
| 245 target_arch=None, skip_archive_steps=False): | 245 target_arch=None, skip_archive_steps=False): |
| 246 if factory_properties is None: | 246 if factory_properties is None: |
| 247 factory_properties = {} | 247 factory_properties = {} |
| 248 factory_properties.setdefault('gclient_env', {}) | 248 factory_properties.setdefault('gclient_env', {}) |
| 249 gclient_env = factory_properties['gclient_env'] | 249 gclient_env = factory_properties['gclient_env'] |
| 250 if options and '--build-tool=ninja' in options: | |
| 251 gclient_env['GYP_GENERATORS'] = 'ninja' | |
|
Nico
2016/06/23 16:58:28
GYP_GENERATORS has defaulted to ninja for desktop
| |
| 252 | 250 |
| 253 # Create the spec for the solutions | 251 # Create the spec for the solutions |
| 254 gclient_spec = self.BuildGClientSpec(tests) | 252 gclient_spec = self.BuildGClientSpec(tests) |
| 255 | 253 |
| 256 # Initialize the factory with the basic steps. | 254 # Initialize the factory with the basic steps. |
| 257 factory = self.BaseFactory(gclient_spec, | 255 factory = self.BaseFactory(gclient_spec, |
| 258 factory_properties=factory_properties, | 256 factory_properties=factory_properties, |
| 259 slave_type=slave_type, | 257 slave_type=slave_type, |
| 260 gclient_deps=gclient_deps, options=options) | 258 gclient_deps=gclient_deps, options=options) |
| 261 | 259 |
| (...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 386 | 384 |
| 387 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect', | 385 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect', |
| 388 'TrybotTester', 'TrybotBuilder'): | 386 'TrybotTester', 'TrybotBuilder'): |
| 389 factory_cmd_obj.AddApplyIssueStep( | 387 factory_cmd_obj.AddApplyIssueStep( |
| 390 timeout=timeout, | 388 timeout=timeout, |
| 391 server=config.Master.Master4.code_review_site, | 389 server=config.Master.Master4.code_review_site, |
| 392 revision_mapping=self._revision_mapping) | 390 revision_mapping=self._revision_mapping) |
| 393 | 391 |
| 394 if not self._nohooks_on_update: | 392 if not self._nohooks_on_update: |
| 395 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout, options=options) | 393 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout, options=options) |
| OLD | NEW |