scripts/master/factory/gclient_factory.py - Issue 2092543005: Stop passing --build-tool=ninja in master configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/master/factory/gclient_factory.py

Issue 2092543005: Stop passing --build-tool=ninja in master configs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/master/factory/gclient_factory.py

diff --git a/scripts/master/factory/gclient_factory.py b/scripts/master/factory/gclient_factory.py

index b1a94acb41f6136e521dcc88942a0310c9e692f9..9e251b435b4a4448d77020dc50ca4132c924063a 100644

--- a/scripts/master/factory/gclient_factory.py

+++ b/scripts/master/factory/gclient_factory.py

@@ -247,8 +247,6 @@ class GClientFactory(object):

factory_properties = {}

factory_properties.setdefault('gclient_env', {})

gclient_env = factory_properties['gclient_env']

- if options and '--build-tool=ninja' in options:

- gclient_env['GYP_GENERATORS'] = 'ninja'

Nico 2016/06/23 16:58:28 GYP_GENERATORS has defaulted to ninja for desktop

# Create the spec for the solutions

gclient_spec = self.BuildGClientSpec(tests)

« scripts/master/factory/dart/dart_factory.py ('K') | « scripts/master/factory/dart/dart_factory.py ('k') | no next file » | no next file with comments »