Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Side by Side Diff: scripts/master/factory/dart/dart_factory.py

Issue 2092543005: Stop passing --build-tool=ninja in master configs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Utility class to generate a Dart-specific BuildFactory. 6 """Utility class to generate a Dart-specific BuildFactory.
7 7
8 Based on gclient_factory.py. 8 Based on gclient_factory.py.
9 """ 9 """
10 10
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 if trigger_schedulers: 325 if trigger_schedulers:
326 dart_cmd_obj.AddTrigger(trigger.Trigger( 326 dart_cmd_obj.AddTrigger(trigger.Trigger(
327 schedulerNames=trigger_schedulers, 327 schedulerNames=trigger_schedulers,
328 waitForFinish=False, 328 waitForFinish=False,
329 updateSourceStamp=False)) 329 updateSourceStamp=False))
330 330
331 return factory 331 return factory
332 332
333 333
334 class DartUtils(object): 334 class DartUtils(object):
335 mac_options = ['--compiler=goma-clang', 335 mac_options = ['--compiler=goma', 'dartium_builder']
Nico 2016/06/23 16:58:28 goma-clang and goma mean the same thing these days
336 '--build-tool=ninja', 336 linux_options = ['--compiler=goma', 'dartium_builder']
337 'dartium_builder'] 337 win_options = ['dartium_builder']
338 linux_options = ['--compiler=goma', '--build-tool=ninja', 'dartium_builder']
339 win_options = ['--build-tool=ninja', 'dartium_builder']
340 338
341 339
342 win_rel_factory_properties = { 340 win_rel_factory_properties = {
343 'gclient_env': { 341 'gclient_env': {
344 'GYP_DEFINES': 'fastbuild=1', 342 'GYP_DEFINES': 'fastbuild=1',
345 }, 343 },
346 'gclient_transitive': True, 344 'gclient_transitive': True,
347 'no_gclient_branch': True, 345 'no_gclient_branch': True,
348 'gclient_timeout': 3600, 346 'gclient_timeout': 3600,
349 'annotated_script': 'dart_buildbot_run.py', 347 'annotated_script': 'dart_buildbot_run.py',
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 builders=notifying_builders)) 727 builders=notifying_builders))
730 else: 728 else:
731 statuses.append( 729 statuses.append(
732 MailNotifier(fromaddr=self._active_master.from_address, 730 MailNotifier(fromaddr=self._active_master.from_address,
733 mode='problem', 731 mode='problem',
734 sendToInterestedUsers=send_to_interested_useres, 732 sendToInterestedUsers=send_to_interested_useres,
735 extraRecipients=extra_recipients, 733 extraRecipients=extra_recipients,
736 lookup=master_utils.UsersAreEmails(), 734 lookup=master_utils.UsersAreEmails(),
737 builders=notifying_builders)) 735 builders=notifying_builders))
738 return statuses 736 return statuses
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698