Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1918)

Unified Diff: scripts/master/factory/dart/dart_factory.py

Issue 2092543005: Stop passing --build-tool=ninja in master configs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/dart/dart_factory.py
diff --git a/scripts/master/factory/dart/dart_factory.py b/scripts/master/factory/dart/dart_factory.py
index 1a04a4f6a7745cdb489b8fc747bad47836631578..ca03864baed293c625d849535efb8598e76c4d24 100644
--- a/scripts/master/factory/dart/dart_factory.py
+++ b/scripts/master/factory/dart/dart_factory.py
@@ -332,11 +332,9 @@ class PackageFactory(gclient_factory.GClientFactory):
class DartUtils(object):
- mac_options = ['--compiler=goma-clang',
Nico 2016/06/23 16:58:28 goma-clang and goma mean the same thing these days
- '--build-tool=ninja',
- 'dartium_builder']
- linux_options = ['--compiler=goma', '--build-tool=ninja', 'dartium_builder']
- win_options = ['--build-tool=ninja', 'dartium_builder']
+ mac_options = ['--compiler=goma', 'dartium_builder']
+ linux_options = ['--compiler=goma', 'dartium_builder']
+ win_options = ['dartium_builder']
win_rel_factory_properties = {

Powered by Google App Engine
This is Rietveld 408576698