Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2088833003: Add different behavior to AwakableList for "persistent" vs "one-shot" awakables. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work793_wait_set_4.5
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add different behavior to AwakableList for "persistent" vs "one-shot" awakables. * See the comment above AwakableList::Add()'s declaration for details about the distinction between persistent and one-shot. * Rename various |force| parameters to (Add()/AddAwakable()/etc.) to |persistent|. * A lot more work has to be done in WaitSetDispatcher, but this change is already too big, so I did the minimum amount to keep it sane. * Also, more tests should be added. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/744cd1ce0ce541ec99d8ac69d851141dd160e230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -217 lines) Patch
M mojo/edk/system/async_waiter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/async_waiter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/awakable.h View 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/edk/system/awakable.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/awakable_list.h View 2 chunks +29 lines, -5 lines 0 comments Download
M mojo/edk/system/awakable_list.cc View 3 chunks +31 lines, -14 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 21 chunks +58 lines, -75 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/simple_dispatcher.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 2 chunks +2 lines, -7 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 3 chunks +29 lines, -35 lines 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +10 lines, -5 lines 0 comments Download
M mojo/edk/system/waiter.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2084593005/.
4 years, 6 months ago (2016-06-21 22:30:02 UTC) #1
viettrungluu
ping (note: more tests coming in the next CL)
4 years, 6 months ago (2016-06-22 18:14:28 UTC) #2
viettrungluu
ping again
4 years, 6 months ago (2016-06-23 00:38:26 UTC) #3
vardhan
lgtm
4 years, 6 months ago (2016-06-23 00:40:15 UTC) #4
viettrungluu
4 years, 6 months ago (2016-06-23 01:11:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
744cd1ce0ce541ec99d8ac69d851141dd160e230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698