Issue 2085583006: Add more tests for AwakableList (esp. persistent vs one-shot awakables).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2085583006: Add more tests for AwakableList (esp. persistent vs one-shot awakables). (Closed)

Created:
4 years, 6 months ago by viettrungluu

Modified:
4 years, 6 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@work794_wait_set_4.6

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add more tests for AwakableList (esp. persistent vs one-shot awakables). R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/99cd65b364f2710c39ee612d0a28f7e99dedf6d8

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+309 lines, -29 lines)			Patch
	M	mojo/edk/system/awakable_list.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	mojo/edk/system/awakable_list_unittest.cc	View		3 chunks	+305 lines, -28 lines	0 comments	Download

Depends on Patchset:

Issue 2088833003 Patch 1

Dependent Patchsets:

Issue 2090763002 Patch 1

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 6 months ago (2016-06-23 16:45:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
99cd65b364f2710c39ee612d0a28f7e99dedf6d8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages