Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: mojo/edk/system/local_message_pipe_endpoint.cc

Issue 2088833003: Add different behavior to AwakableList for "persistent" vs "one-shot" awakables. (Closed) Base URL: https://github.com/domokit/mojo.git@work793_wait_set_4.5
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/local_message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/local_message_pipe_endpoint.cc
diff --git a/mojo/edk/system/local_message_pipe_endpoint.cc b/mojo/edk/system/local_message_pipe_endpoint.cc
index af5915593807ba3195b266a71fd7f2f2d14d9058..77088855e6adb20c60ba986bff665cee97633e53 100644
--- a/mojo/edk/system/local_message_pipe_endpoint.cc
+++ b/mojo/edk/system/local_message_pipe_endpoint.cc
@@ -65,7 +65,7 @@ void LocalMessagePipeEndpoint::Close() {
void LocalMessagePipeEndpoint::CancelAllState() {
DCHECK(is_open_);
- awakable_list_.CancelAll();
+ awakable_list_.CancelAndRemoveAll();
}
MojoResult LocalMessagePipeEndpoint::ReadMessage(
@@ -151,7 +151,7 @@ HandleSignalsState LocalMessagePipeEndpoint::GetHandleSignalsState() const {
MojoResult LocalMessagePipeEndpoint::AddAwakable(
Awakable* awakable,
uint64_t context,
- bool force,
+ bool persistent,
MojoHandleSignals signals,
HandleSignalsState* signals_state) {
DCHECK(is_open_);
@@ -160,17 +160,17 @@ MojoResult LocalMessagePipeEndpoint::AddAwakable(
if (signals_state)
*signals_state = state;
if (state.satisfies(signals)) {
- if (force)
- awakable_list_.Add(awakable, context, signals);
+ if (persistent)
+ awakable_list_.Add(awakable, context, persistent, signals);
return MOJO_RESULT_ALREADY_EXISTS;
}
if (!state.can_satisfy(signals)) {
- if (force)
- awakable_list_.Add(awakable, context, signals);
+ if (persistent)
+ awakable_list_.Add(awakable, context, persistent, signals);
return MOJO_RESULT_FAILED_PRECONDITION;
}
- awakable_list_.Add(awakable, context, signals);
+ awakable_list_.Add(awakable, context, persistent, signals);
return MOJO_RESULT_OK;
}
« no previous file with comments | « mojo/edk/system/local_message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698