Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: mojo/edk/system/data_pipe.cc

Issue 2088833003: Add different behavior to AwakableList for "persistent" vs "one-shot" awakables. (Closed) Base URL: https://github.com/domokit/mojo.git@work793_wait_set_4.5
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/data_pipe.h ('k') | mojo/edk/system/data_pipe_consumer_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/data_pipe.cc
diff --git a/mojo/edk/system/data_pipe.cc b/mojo/edk/system/data_pipe.cc
index 42c4d6e7ad002b8521475fb8b218d73010a7647c..9c54a09a6ebca6e19c3e09f24c15d5d4fe00c67a 100644
--- a/mojo/edk/system/data_pipe.cc
+++ b/mojo/edk/system/data_pipe.cc
@@ -393,7 +393,7 @@ HandleSignalsState DataPipe::ProducerGetHandleSignalsState() {
MojoResult DataPipe::ProducerAddAwakable(Awakable* awakable,
uint64_t context,
- bool force,
+ bool persistent,
MojoHandleSignals signals,
HandleSignalsState* signals_state) {
MutexLocker locker(&mutex_);
@@ -403,17 +403,17 @@ MojoResult DataPipe::ProducerAddAwakable(Awakable* awakable,
if (signals_state)
*signals_state = producer_state;
if (producer_state.satisfies(signals)) {
- if (force)
- producer_awakable_list_->Add(awakable, context, signals);
+ if (persistent)
+ producer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_ALREADY_EXISTS;
}
if (!producer_state.can_satisfy(signals)) {
- if (force)
- producer_awakable_list_->Add(awakable, context, signals);
+ if (persistent)
+ producer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_FAILED_PRECONDITION;
}
- producer_awakable_list_->Add(awakable, context, signals);
+ producer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_OK;
}
@@ -607,7 +607,7 @@ HandleSignalsState DataPipe::ConsumerGetHandleSignalsState() {
MojoResult DataPipe::ConsumerAddAwakable(Awakable* awakable,
uint64_t context,
- bool force,
+ bool persistent,
MojoHandleSignals signals,
HandleSignalsState* signals_state) {
MutexLocker locker(&mutex_);
@@ -617,17 +617,17 @@ MojoResult DataPipe::ConsumerAddAwakable(Awakable* awakable,
if (signals_state)
*signals_state = consumer_state;
if (consumer_state.satisfies(signals)) {
- if (force)
- consumer_awakable_list_->Add(awakable, context, signals);
+ if (persistent)
+ consumer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_ALREADY_EXISTS;
}
if (!consumer_state.can_satisfy(signals)) {
- if (force)
- consumer_awakable_list_->Add(awakable, context, signals);
+ if (persistent)
+ consumer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_FAILED_PRECONDITION;
}
- consumer_awakable_list_->Add(awakable, context, signals);
+ consumer_awakable_list_->Add(awakable, context, persistent, signals);
return MOJO_RESULT_OK;
}
@@ -719,7 +719,7 @@ std::unique_ptr<DataPipeImpl> DataPipe::ReplaceImplNoLock(
void DataPipe::ProducerCancelAllStateNoLock() {
DCHECK(has_local_producer_no_lock());
if (producer_awakable_list_)
- producer_awakable_list_->CancelAll();
+ producer_awakable_list_->CancelAndRemoveAll();
// Not a bug, except possibly in "user" code.
DVLOG_IF(2, producer_in_two_phase_write_no_lock())
<< "Active two-phase write cancelled";
@@ -729,7 +729,7 @@ void DataPipe::ProducerCancelAllStateNoLock() {
void DataPipe::ConsumerCancelAllStateNoLock() {
DCHECK(has_local_consumer_no_lock());
if (consumer_awakable_list_)
- consumer_awakable_list_->CancelAll();
+ consumer_awakable_list_->CancelAndRemoveAll();
// Not a bug, except possibly in "user" code.
DVLOG_IF(2, consumer_in_two_phase_read_no_lock())
<< "Active two-phase read cancelled";
« no previous file with comments | « mojo/edk/system/data_pipe.h ('k') | mojo/edk/system/data_pipe_consumer_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698