Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: mojo/edk/system/simple_dispatcher.cc

Issue 2088833003: Add different behavior to AwakableList for "persistent" vs "one-shot" awakables. (Closed) Base URL: https://github.com/domokit/mojo.git@work793_wait_set_4.5
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/system/simple_dispatcher.h ('k') | mojo/edk/system/wait_set_dispatcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/system/simple_dispatcher.h" 5 #include "mojo/edk/system/simple_dispatcher.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace mojo { 9 namespace mojo {
10 namespace system { 10 namespace system {
11 11
12 SimpleDispatcher::SimpleDispatcher() {} 12 SimpleDispatcher::SimpleDispatcher() {}
13 13
14 SimpleDispatcher::~SimpleDispatcher() {} 14 SimpleDispatcher::~SimpleDispatcher() {}
15 15
16 void SimpleDispatcher::OnHandleSignalsStateChangeNoLock( 16 void SimpleDispatcher::OnHandleSignalsStateChangeNoLock(
17 const HandleSignalsState& old_state, 17 const HandleSignalsState& old_state,
18 const HandleSignalsState& new_state) { 18 const HandleSignalsState& new_state) {
19 mutex().AssertHeld(); 19 mutex().AssertHeld();
20 awakable_list_.OnStateChange(old_state, new_state); 20 awakable_list_.OnStateChange(old_state, new_state);
21 } 21 }
22 22
23 void SimpleDispatcher::CancelAllStateNoLock() { 23 void SimpleDispatcher::CancelAllStateNoLock() {
24 mutex().AssertHeld(); 24 mutex().AssertHeld();
25 awakable_list_.CancelAll(); 25 awakable_list_.CancelAndRemoveAll();
26 } 26 }
27 27
28 MojoResult SimpleDispatcher::AddAwakableImplNoLock( 28 MojoResult SimpleDispatcher::AddAwakableImplNoLock(
29 Awakable* awakable, 29 Awakable* awakable,
30 uint64_t context, 30 uint64_t context,
31 bool force, 31 bool persistent,
32 MojoHandleSignals signals, 32 MojoHandleSignals signals,
33 HandleSignalsState* signals_state) { 33 HandleSignalsState* signals_state) {
34 mutex().AssertHeld(); 34 mutex().AssertHeld();
35 35
36 HandleSignalsState state(GetHandleSignalsStateImplNoLock()); 36 HandleSignalsState state(GetHandleSignalsStateImplNoLock());
37 if (signals_state) 37 if (signals_state)
38 *signals_state = state; 38 *signals_state = state;
39 if (state.satisfies(signals)) { 39 if (state.satisfies(signals)) {
40 if (force) 40 if (persistent)
41 awakable_list_.Add(awakable, context, signals); 41 awakable_list_.Add(awakable, context, persistent, signals);
42 return MOJO_RESULT_ALREADY_EXISTS; 42 return MOJO_RESULT_ALREADY_EXISTS;
43 } 43 }
44 if (!state.can_satisfy(signals)) { 44 if (!state.can_satisfy(signals)) {
45 if (force) 45 if (persistent)
46 awakable_list_.Add(awakable, context, signals); 46 awakable_list_.Add(awakable, context, persistent, signals);
47 return MOJO_RESULT_FAILED_PRECONDITION; 47 return MOJO_RESULT_FAILED_PRECONDITION;
48 } 48 }
49 49
50 awakable_list_.Add(awakable, context, signals); 50 awakable_list_.Add(awakable, context, persistent, signals);
51 return MOJO_RESULT_OK; 51 return MOJO_RESULT_OK;
52 } 52 }
53 53
54 void SimpleDispatcher::RemoveAwakableImplNoLock( 54 void SimpleDispatcher::RemoveAwakableImplNoLock(
55 bool match_context, 55 bool match_context,
56 Awakable* awakable, 56 Awakable* awakable,
57 uint64_t context, 57 uint64_t context,
58 HandleSignalsState* signals_state) { 58 HandleSignalsState* signals_state) {
59 mutex().AssertHeld(); 59 mutex().AssertHeld();
60 awakable_list_.Remove(match_context, awakable, context); 60 awakable_list_.Remove(match_context, awakable, context);
61 if (signals_state) 61 if (signals_state)
62 *signals_state = GetHandleSignalsStateImplNoLock(); 62 *signals_state = GetHandleSignalsStateImplNoLock();
63 } 63 }
64 64
65 } // namespace system 65 } // namespace system
66 } // namespace mojo 66 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/edk/system/simple_dispatcher.h ('k') | mojo/edk/system/wait_set_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698