Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method (Closed)

Created:
4 years, 6 months ago by Marcel Hlopko
Modified:
4 years, 6 months ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kouhei+heap_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method There is no reason why markWrapper should be static method, and making it instance method makes it easier to use other visitors (for example verifying visitor for write barrier checking comes to my mind :) There is a little fight in me whether to call the method markWrapper or traceWrappers. I went with traceWrappers in this cl for consistentcy in all traceWrappers methods. In either case, the same name should be used for ScopedPersistents too. LOG=no BUG=468240 Committed: https://crrev.com/03b8da6059cd836993aaea1039a2be19bdcead4f Cr-Commit-Position: refs/heads/master@{#400974}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Trace EventTarget's listener #

Patch Set 4 : Final polish #

Patch Set 5 : Whitespace fix #

Messages

Total messages: 17 (9 generated)
Marcel Hlopko
Ptal.
4 years, 6 months ago (2016-06-20 16:40:06 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-20 23:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086553002/1
4 years, 6 months ago (2016-06-21 07:58:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/24043) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-21 08:00:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086553002/20001
4 years, 6 months ago (2016-06-21 08:21:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086553002/80001
4 years, 6 months ago (2016-06-21 11:46:42 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-21 13:20:39 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 13:23:50 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/03b8da6059cd836993aaea1039a2be19bdcead4f
Cr-Commit-Position: refs/heads/master@{#400974}

Powered by Google App Engine
This is Rietveld 408576698