Chromium Code Reviews
DescriptionRefactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method
There is no reason why markWrapper should be static method, and making it
instance method makes it easier to use other visitors (for example verifying
visitor for write barrier checking comes to my mind :)
There is a little fight in me whether to call the method markWrapper or
traceWrappers. I went with traceWrappers in this cl for consistentcy in all
traceWrappers methods. In either case, the same name should be used for
ScopedPersistents too.
LOG=no
BUG=468240
Committed: https://crrev.com/03b8da6059cd836993aaea1039a2be19bdcead4f
Cr-Commit-Position: refs/heads/master@{#400974}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Trace EventTarget's listener #Patch Set 4 : Final polish #Patch Set 5 : Whitespace fix #Messages
Total messages: 17 (9 generated)
|