third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp - Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Whitespace fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

index 40a6326e392b07b5befca4b69a8c6934b6e4b516..3c6dee4d4a0da832b3405b4dc9b8524a6037b4d3 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

@@ -138,7 +138,7 @@ void DOMWrapperWorld::allWorldsInMainThread(Vector<RefPtr<DOMWrapperWorld>>& wor

worlds.append(it->value);

}

-void DOMWrapperWorld::markWrappersInAllWorlds(ScriptWrappable* scriptWrappable, v8::Isolate* isolate)

+void DOMWrapperWorld::markWrappersInAllWorlds(ScriptWrappable* scriptWrappable, const WrapperVisitor* visitor)

{

// TODO(hlopko): Currently wrapper in one world will keep wrappers in all

// worlds alive (possibly holding on entire documents). This is neither

@@ -146,7 +146,7 @@ void DOMWrapperWorld::markWrappersInAllWorlds(ScriptWrappable* scriptWrappable,

// (big performance and memory overhead).

// Marking for the main world

- scriptWrappable->markWrapper(isolate);

+ scriptWrappable->markWrapper(visitor);

if (!isMainThread())

return;

WorldMap& isolatedWorlds = isolatedWorldMap();