Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: third_party/WebKit/Source/platform/heap/WrapperVisitor.h

Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whitespace fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/events/EventTarget.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/WrapperVisitor.h
diff --git a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
index d0b0bb8b58f0181de6cb003571ab70d1a7a3c674..a8348bde358dee20dd57ff80c744b73b38c344d3 100644
--- a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
+++ b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
@@ -11,6 +11,7 @@
namespace v8 {
class Value;
class Object;
+template <class T> class PersistentBase;
}
namespace blink {
@@ -32,6 +33,7 @@ template<typename T> class ScopedPersistent;
V(NodeMutationObserverData); \
V(NodeRareData); \
V(StyleEngine); \
+ V(V8AbstractEventListener); \
#define FORWARD_DECLARE_SPECIAL_CLASSES(className) \
class className;
@@ -97,8 +99,9 @@ public:
if (!traceable)
return;
- if (TraceTrait<T>::heapObjectHeader(traceable)->isWrapperHeaderMarked())
+ if (TraceTrait<T>::heapObjectHeader(traceable)->isWrapperHeaderMarked()) {
return;
+ }
pushToMarkingDeque(
TraceTrait<T>::markWrapper,
@@ -112,7 +115,9 @@ public:
traceWrappers(t.get());
}
- virtual void traceWrappers(const ScopedPersistent<v8::Value>*) const = 0;
+ virtual void traceWrappers(const ScopedPersistent<v8::Value>* persistent) const = 0;
+ virtual void traceWrappers(const ScopedPersistent<v8::Object>* persistent) const = 0;
+ virtual void markWrapper(const v8::PersistentBase<v8::Object>* persistent) const = 0;
virtual void dispatchTraceWrappers(const ScriptWrappable*) const = 0;
#define DECLARE_DISPATCH_TRACE_WRAPPERS(className) \
« no previous file with comments | « third_party/WebKit/Source/core/events/EventTarget.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698