third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h - Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Whitespace fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

index ee6e98589347a0285954087f846461787e46f4b5..b1305caacd5edbb4c0831332d226d127501c04b3 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

@@ -149,7 +149,7 @@ public:

* wrapper in the main world. To mark wrappers in all worlds call

* ScriptWrappableVisitor::markWrapper(ScriptWrappable*, v8::Isolate*)

- void markWrapper(v8::Isolate*) const;

+ void markWrapper(const WrapperVisitor*) const;

DECLARE_VIRTUAL_TRACE_WRAPPERS() {};