Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2086553002: Refactor ScriptWrappableVisitor.markWrapper(PersistentBase) to be instance method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whitespace fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
index 59eabbb7fa2bb30a6bc1d8ad171691985714b756..fce3cedc2836ce15975b167acff4181530fc9202 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
@@ -83,14 +83,6 @@ public:
* gc.
*/
static void invalidateDeadObjectsInMarkingDeque(v8::Isolate*);
- /**
- * Mark given wrapper as alive in V8.
- */
- template <typename T>
- static void markWrapper(const v8::Persistent<T>* handle, v8::Isolate* isolate)
- {
- handle->RegisterExternalReference(isolate);
- }
void TracePrologue() override;
void RegisterV8References(const std::vector<std::pair<void*, void*>>& internalFieldsOfPotentialWrappers) override;
@@ -100,12 +92,6 @@ public:
void AbortTracing() override;
void EnterFinalPause() override;
- template <typename T>
- void markWrapper(const v8::Persistent<T>* handle) const
- {
- markWrapper(handle, m_isolate);
- }
-
void dispatchTraceWrappers(const ScriptWrappable*) const override;
#define DECLARE_DISPATCH_TRACE_WRAPPERS(className) \
void dispatchTraceWrappers(const className*) const override;
@@ -116,6 +102,9 @@ public:
void dispatchTraceWrappers(const void*) const override {}
void traceWrappers(const ScopedPersistent<v8::Value>*) const override;
+ void traceWrappers(const ScopedPersistent<v8::Object>*) const override;
+ void markWrapper(const v8::PersistentBase<v8::Value>* handle) const;
+ void markWrapper(const v8::PersistentBase<v8::Object>* handle) const override;
void invalidateDeadObjectsInMarkingDeque();

Powered by Google App Engine
This is Rietveld 408576698