Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2084633002: json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload. BUG=581865 Committed: https://crrev.com/04e34f1e60314dc3b32fdb4a71a143be25fe38bc Cr-Commit-Position: refs/heads/master@{#400728}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/test/additional_properties_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/any_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/functions_on_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/idl_schemas_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/json_schema_compiler/test/test_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/test_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
4 years, 6 months ago (2016-06-20 15:16:24 UTC) #2
Devlin
lgtm https://codereview.chromium.org/2084633002/diff/1/tools/json_schema_compiler/test/arrays_unittest.cc File tools/json_schema_compiler/test/arrays_unittest.cc (right): https://codereview.chromium.org/2084633002/diff/1/tools/json_schema_compiler/test/arrays_unittest.cc#newcode44 tools/json_schema_compiler/test/arrays_unittest.cc:44: static std::unique_ptr<base::DictionaryValue> CreateItemValue(int val) { optional nitty nit: ...
4 years, 6 months ago (2016-06-20 17:14:40 UTC) #3
dcheng
https://codereview.chromium.org/2084633002/diff/1/tools/json_schema_compiler/test/arrays_unittest.cc File tools/json_schema_compiler/test/arrays_unittest.cc (right): https://codereview.chromium.org/2084633002/diff/1/tools/json_schema_compiler/test/arrays_unittest.cc#newcode44 tools/json_schema_compiler/test/arrays_unittest.cc:44: static std::unique_ptr<base::DictionaryValue> CreateItemValue(int val) { On 2016/06/20 17:14:40, Devlin ...
4 years, 6 months ago (2016-06-20 17:24:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084633002/20001
4 years, 6 months ago (2016-06-20 17:24:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 18:14:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:19:02 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/04e34f1e60314dc3b32fdb4a71a143be25fe38bc
Cr-Commit-Position: refs/heads/master@{#400728}

Powered by Google App Engine
This is Rietveld 408576698