Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: tools/json_schema_compiler/test/test_util.h

Issue 2084633002: json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/test_util.h
diff --git a/tools/json_schema_compiler/test/test_util.h b/tools/json_schema_compiler/test/test_util.h
index d82e90512d5c1dc38acc53296283ab3c8f672a4b..87145fda5a4e7afa0c39c8da13235e3c7b7d0362 100644
--- a/tools/json_schema_compiler/test/test_util.h
+++ b/tools/json_schema_compiler/test/test_util.h
@@ -34,6 +34,8 @@ std::vector<T> Vector(const T& a, const T& b, const T& c) {
return arr;
}
+// TODO(dcheng): These various helpers should all take std::unique_ptr
+// arguments. See https://crbug.com/581865.
std::unique_ptr<base::ListValue> List(base::Value* a);
std::unique_ptr<base::ListValue> List(base::Value* a, base::Value* b);
std::unique_ptr<base::ListValue> List(base::Value* a,
« no previous file with comments | « tools/json_schema_compiler/test/idl_schemas_unittest.cc ('k') | tools/json_schema_compiler/test/test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698