json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload.

tools/json_schema_compiler/test/arrays_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/json_schema_compiler/test/arrays.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 23 matching lines @@
   booleans_value->AppendBoolean(true);
   base::ListValue* numbers_value = new base::ListValue();
   numbers_value->AppendDouble(6.1);
   value->Set("numbers", numbers_value);
   value->Set("booleans", booleans_value);
   value->Set("strings", strings_value);
   value->Set("integers", integers_value);
   return value;
 }
 
-static base::Value* CreateItemValue(int val) {
-  base::DictionaryValue* value(new base::DictionaryValue());
+static std::unique_ptr<base::DictionaryValue> CreateItemValue(int val) {

[Devlin, 2016/06/20 17:14:40]

optional nitty nit: remove static, since this is already in an optional
namespace.

[dcheng, 2016/06/20 17:24:29]

Done.

+  std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
   value->Set("val", new base::FundamentalValue(val));
   return value;
 }
 
 }  // namespace
 
 TEST(JsonSchemaCompilerArrayTest, BasicArrayType) {
   {
     std::unique_ptr<base::DictionaryValue> value =
         CreateBasicArrayTypeDictionary();
@@ skipping 213 matching lines @@
   std::unique_ptr<base::ListValue> expected_argument(new base::ListValue());
   std::unique_ptr<base::DictionaryValue> first(new base::DictionaryValue());
   first->SetInteger("val", 1);
   expected_argument->Append(std::move(first));
   std::unique_ptr<base::DictionaryValue> second(new base::DictionaryValue());
   second->SetInteger("val", 2);
   expected_argument->Append(std::move(second));
   expected.Append(std::move(expected_argument));
   EXPECT_TRUE(results->Equals(&expected));
 }