Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/json_schema_compiler/test/idl_schemas_unittest.cc

Issue 2084633002: json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/idl_schemas_unittest.cc
diff --git a/tools/json_schema_compiler/test/idl_schemas_unittest.cc b/tools/json_schema_compiler/test/idl_schemas_unittest.cc
index 139f4df15ab36f505ed180976f9d05033e9283ad..07df4fb5ef93062efb1200532b8235e50a46db16 100644
--- a/tools/json_schema_compiler/test/idl_schemas_unittest.cc
+++ b/tools/json_schema_compiler/test/idl_schemas_unittest.cc
@@ -5,6 +5,7 @@
#include <memory>
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "tools/json_schema_compiler/test/idl_basics.h"
@@ -129,7 +130,7 @@ TEST(IdlCompiler, ArrayTypes) {
// use an empty array.
base::ListValue list;
list.AppendInteger(33);
- list.Append(new base::ListValue);
+ list.Append(base::MakeUnique<base::ListValue>());
std::unique_ptr<Function10::Params> f10_params =
Function10::Params::Create(list);
ASSERT_TRUE(f10_params != NULL);
« no previous file with comments | « tools/json_schema_compiler/test/functions_on_types_unittest.cc ('k') | tools/json_schema_compiler/test/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698