Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/json_schema_compiler/test/any_unittest.cc

Issue 2084633002: json_schema_compiler: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/any_unittest.cc
diff --git a/tools/json_schema_compiler/test/any_unittest.cc b/tools/json_schema_compiler/test/any_unittest.cc
index 52587e7edee1ed7a533fb6b443f252bb2d3e392f..8952190aeb44f0b4df315d9afc1c03bf7c8fee22 100644
--- a/tools/json_schema_compiler/test/any_unittest.cc
+++ b/tools/json_schema_compiler/test/any_unittest.cc
@@ -39,7 +39,7 @@ TEST(JsonSchemaCompilerAnyTest, OptionalAnyParamsCreate) {
{
std::unique_ptr<base::ListValue> params_value(new base::ListValue());
std::unique_ptr<base::Value> param(new base::StringValue("asdf"));
- params_value->Append(param->DeepCopy());
+ params_value->Append(param->CreateDeepCopy());
std::unique_ptr<OptionalAny::Params> params(
OptionalAny::Params::Create(*params_value));
ASSERT_TRUE(params);
@@ -49,7 +49,7 @@ TEST(JsonSchemaCompilerAnyTest, OptionalAnyParamsCreate) {
{
std::unique_ptr<base::ListValue> params_value(new base::ListValue());
std::unique_ptr<base::Value> param(new base::FundamentalValue(true));
- params_value->Append(param->DeepCopy());
+ params_value->Append(param->CreateDeepCopy());
std::unique_ptr<OptionalAny::Params> params(
OptionalAny::Params::Create(*params_value));
ASSERT_TRUE(params);
« no previous file with comments | « tools/json_schema_compiler/test/additional_properties_unittest.cc ('k') | tools/json_schema_compiler/test/arrays_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698