Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode (Closed)

Created:
4 years, 6 months ago by watk
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, qinmin
CC:
chromium-reviews, szager+layoutwatch_chromium.org, posciak+watch_chromium.org, gasubic, eae+blinkwatch, fs, eric.carlson_apple.com, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, blink-reviews-html_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, jchaffraix+rendering, blink-reviews, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, nessy, zoltan1, blink-reviews-layout_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, vcarbune.chromium, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, avayvod+watch_chromium.org, leviw+renderwatch, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the video layer visibility configurable in OverlayFullscreenVideo mode OverlayFullscreenVideo initially always hid the video GraphicsLayer, but that was changed to always show it in http://crrev.com/1907753002. That approach doesn't work when the media player is WebMediaPlayerAndroid and the video has a background image because it made the background visible. This CL reverts that change to do it a better way: now the WebMediaPlayer can choose whether the video layer is hidden. So WMPA can hide it as it always has, and WMPI can make it visible. TEST=LayoutTests BUG=615245, 603521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-specified-size-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
watk
Hey chrishtr, PTAL at the blink changes. qinmin@, PTAL at WMPA. The changes are pretty ...
4 years, 6 months ago (2016-06-21 21:45:01 UTC) #2
watk
Note: I will need to merge this back to M52 to fix the regression with ...
4 years, 6 months ago (2016-06-21 21:54:32 UTC) #4
watk
4 years, 6 months ago (2016-06-22 00:29:27 UTC) #5
qinmin@, you can disregard this for now. Working on a different fix suggested by
chrishtr@.

Powered by Google App Engine
This is Rietveld 408576698