content/renderer/media/android/webmediaplayer_android.h - Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 6f407c8c2844dd345fc0a50ca23e9ef8f27817ad..2858f69a82798560f4066d83ab347153053adf53 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -101,7 +101,8 @@ class WebMediaPlayerAndroid

~WebMediaPlayerAndroid() override;

// blink::WebMediaPlayer implementation.

- bool supportsOverlayFullscreenVideo() override;

+ WebMediaPlayer::OverlayFullscreenVideoMode getOverlayFullscreenVideoMode()

+ override;

void enteredFullscreen() override;

// Resource loading.

@@ -347,9 +348,6 @@ class WebMediaPlayerAndroid

scoped_refptr<media::VideoFrame> current_frame_;

base::Lock current_frame_lock_;

- // A lazily created transparent video frame to be displayed in fullscreen.

- scoped_refptr<media::VideoFrame> fullscreen_frame_;

base::ThreadChecker main_thread_checker_;

// Message loop for media thread.

« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »