Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index 9979e856dae347c8f0d7c1aa103727dd3751640c..826a5db2761c2672d8639c158246ec91940b4ae5 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -105,6 +105,16 @@ public:
typedef WebString TrackId;
enum TrackType { TextTrack, AudioTrack, VideoTrack };
+ // Overlay fullscreen video can work in these modes. VideoLayerVisible will
+ // leave the contents of the GraphicsLayer associated with the video element
+ // visible, whereas VideoLayerInvisible will hide it so that only the
+ // controls are visible.
+ enum class OverlayFullscreenVideoMode {
+ Disabled,
+ VideoLayerVisible,
+ VideoLayerInvisible,
+ };
+
virtual ~WebMediaPlayer() { }
virtual void load(LoadType, const WebMediaPlayerSource&, CORSMode) = 0;
@@ -188,11 +198,8 @@ public:
// Sets the poster image URL.
virtual void setPoster(const WebURL& poster) { }
- // Whether the WebMediaPlayer supports overlay fullscreen video mode. When
- // this is true, the video layer will be removed from the layer tree when
- // entering fullscreen, and the WebMediaPlayer is responsible for displaying
- // the video in enteredFullscreen().
- virtual bool supportsOverlayFullscreenVideo() { return false; }
+ // Which OverlayFullscreenVideoMode should be used in fullscren.
+ virtual OverlayFullscreenVideoMode getOverlayFullscreenVideoMode() { return OverlayFullscreenVideoMode::Disabled; }
// Inform WebMediaPlayer when the element has entered/exited fullscreen.
virtual void enteredFullscreen() { }
virtual void exitedFullscreen() { }
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698