Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 55f0bb4d99353073a1ff048adbf3a11e138aefe7..6a09b19025fed562385ee4ba3d052db94f7d6427 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -268,7 +268,8 @@ void WebMediaPlayerImpl::load(LoadType load_type,
DoLoad(load_type, url, cors_mode);
}
-bool WebMediaPlayerImpl::supportsOverlayFullscreenVideo() {
+WebMediaPlayer::OverlayFullscreenVideoMode
+WebMediaPlayerImpl::getOverlayFullscreenVideoMode() {
#if defined(OS_ANDROID)
// OverlayFullscreenVideo is only used when we're H/W decoding to an
// SurfaceView underlay on Android. It's possible that we haven't initialized
@@ -285,9 +286,11 @@ bool WebMediaPlayerImpl::supportsOverlayFullscreenVideo() {
supports_overlay_fullscreen_video_ =
decoder_requires_restart_for_fullscreen_;
}
- return supports_overlay_fullscreen_video_;
+ return supports_overlay_fullscreen_video_
+ ? WebMediaPlayer::OverlayFullscreenVideoMode::VideoLayerVisible
+ : WebMediaPlayer::OverlayFullscreenVideoMode::Disabled;
#else
- return false;
+ return WebMediaPlayer::OverlayFullscreenVideoMode::Disabled;
#endif
}

Powered by Google App Engine
This is Rietveld 408576698