third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2084223002: Make the video layer visibility configurable in OverlayFullscreenVideo mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLVideoElement.h ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index 04ae3c0f4c4b88d04dc13ea5d87e69732cfcd376..1bac23600c929c962234463fbe5cac2460d6c1a3 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -249,10 +249,15 @@ bool HTMLVideoElement::webkitDisplayingFullscreen()

bool HTMLVideoElement::usesOverlayFullscreenVideo() const

{

+ return overlayFullscreenVideoMode() != WebMediaPlayer::OverlayFullscreenVideoMode::Disabled;

+WebMediaPlayer::OverlayFullscreenVideoMode HTMLVideoElement::overlayFullscreenVideoMode() const

if (RuntimeEnabledFeatures::forceOverlayFullscreenVideoEnabled())

- return true;

+ return WebMediaPlayer::OverlayFullscreenVideoMode::VideoLayerInvisible;

- return webMediaPlayer() && webMediaPlayer()->supportsOverlayFullscreenVideo();

+ return webMediaPlayer() ? webMediaPlayer()->getOverlayFullscreenVideoMode() : WebMediaPlayer::OverlayFullscreenVideoMode::Disabled;

}

void HTMLVideoElement::didMoveToNewDocument(Document& oldDocument)