Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed)

Created:
4 years, 6 months ago by kotenkov
Modified:
4 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ASSERT -> DCHECK conversions in core/editing. ENABLE(ASSERT) -> DCHECK_IS_ON() in core/editing. ASSERT_NOT_REACHED() -> NOTREACHED() in core/editing. BUG=596760 Committed: https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268 Cr-Commit-Position: refs/heads/master@{#400923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditingState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditingState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kotenkov
Another CL with ASSERT -> DCHECK conversion. One of these ENABLE(ASSERT) was causing a compilation ...
4 years, 6 months ago (2016-06-21 08:31:57 UTC) #2
yosin_UTC9
lgtm Thanks!
4 years, 6 months ago (2016-06-21 08:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082503003/1
4 years, 6 months ago (2016-06-21 08:43:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 08:48:10 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 08:49:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/673555a5d9c7a1bc26dc67813e1110cdc2e07268
Cr-Commit-Position: refs/heads/master@{#400923}

Powered by Google App Engine
This is Rietveld 408576698