third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2082503003: ASSERT -> DCHECK conversions in core/editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2082503003: ASSERT -> DCHECK conversions in core/editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index ed6699fed74eda54db3a4f00fd3a3a34b6629dbd..a4488b6ae8e8784634c77c75f5f3a57de5d869fa 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -73,7 +73,7 @@ DocumentMarker::MarkerTypeIndex MarkerTypeToMarkerIndex(DocumentMarker::MarkerTy

return DocumentMarker::CompositionMarkerIndex;

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return DocumentMarker::SpellingMarkerIndex;

}

@@ -702,7 +702,7 @@ void DocumentMarkerController::shiftMarkers(Node* node, unsigned startOffset, in

continue;

MarkerList::iterator startPos = std::lower_bound(list->begin(), list->end(), startOffset, startsAfter);

for (MarkerList::iterator marker = startPos; marker != list->end(); ++marker) {

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

int startOffset = (*marker)->startOffset();

DCHECK_GE(startOffset + delta, 0);

#endif